Fold TYP_STRUCT indirect access to promoted locals
#71584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThese are mostly We're expecting broadly positive diffs with some regression due to how new forward substitutions affect various transformations.
|
Closed
|
@dotnet/jit-contrib |
SingleAccretion
force-pushed
the
LclMorph-Promotion-Structs
branch
from
892778d
to
32bb7f8
Compare
SingleAccretion
force-pushed
the
LclMorph-Promotion-Structs
branch
from
32bb7f8
to
dbb757f
Compare
jakobbotsch
approved these changes
Aug 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are mostly
OBJ(ADDR(LCL_VAR))constructions, but can also be local fields.Broadly positive diffs with some regression due to how new forward substitutions affect various transformations. In particular, there is a regression on x86 due to more aggressive CSE that is replicated across many generated methods.
Also a nice TP win across the board.