Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyfill the incremental generator ForAttributeWithMetadataName from roslyn (for LoggingGenerator). #71651

Merged
merged 6 commits into from
Jul 7, 2022
Merged

Polyfill the incremental generator ForAttributeWithMetadataName from roslyn (for LoggingGenerator). #71651

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dad6fc2
Polyfill the incremental generator ForAttributeWithMetadataName from …
CyrusNajmabadi Jul 5, 2022
32eb2f8
Simplify
CyrusNajmabadi Jul 5, 2022
e63a0f9
Merge remote-tracking branch 'upstream/main' into loggingGenerator
CyrusNajmabadi Jul 6, 2022
c4e36d4
Fix project file
CyrusNajmabadi Jul 6, 2022
93a6327
Remove
CyrusNajmabadi Jul 6, 2022
a1f5727
revert
CyrusNajmabadi Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify
  • Loading branch information
@CyrusNajmabadi
CyrusNajmabadi committed Jul 5, 2022
commit 32eb2f870fb4382c703ba7926cec139fab3774a6
3 changes: 0 additions & 3 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public Parser(Compilation compilation, Action<Diagnostic> reportDiagnostic, Canc
_reportDiagnostic = reportDiagnostic;
}

internal static bool IsSyntaxTargetForGeneration(SyntaxNode node) =>
node is MethodDeclarationSyntax m && m.AttributeLists.Count > 0;

/// <summary>
/// Gets the set of logging classes containing methods to output.
/// </summary>
Expand Down
7 changes: 5 additions & 2 deletions ...raries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Roslyn3.11.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ internal static ISyntaxContextReceiver Create()

public void OnVisitSyntaxNode(GeneratorSyntaxContext context)
{
if (Parser.IsSyntaxTargetForGeneration(context.Node))
if (IsSyntaxTargetForGeneration(context.Node))
{
ClassDeclarationSyntax classSyntax = GetSemanticTargetForGeneration(context);
if (classSyntax != null)
Expand All @@ -59,7 +59,10 @@ public void OnVisitSyntaxNode(GeneratorSyntaxContext context)
}
}

internal static ClassDeclarationSyntax? GetSemanticTargetForGeneration(GeneratorSyntaxContext context)
private static bool IsSyntaxTargetForGeneration(SyntaxNode node) =>
node is MethodDeclarationSyntax m && m.AttributeLists.Count > 0;

private static ClassDeclarationSyntax? GetSemanticTargetForGeneration(GeneratorSyntaxContext context)
{
var methodDeclarationSyntax = (MethodDeclarationSyntax)context.Node;

Expand Down