Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -unicode instead of /unicode for linux ildasm roundtrip tests #71958

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Jul 11, 2022

Use -unicode instead of /unicode for linux ildasm roundtrip tests

Use `-unicode` instead of `/unicode` for linux ildasm roundtrip tests
@ghost
Copy link

ghost commented Jul 11, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Use -unicode instead of /unicode for linux ildasm roundtrip tests

Author: TIHan
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

@BruceForstall
Copy link
Member

/azp run runtime-coreclr ilasm

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@dotnet dotnet deleted a comment from azure-pipelines bot Jul 11, 2022
@BruceForstall
Copy link
Member

I manually triggered it: https://dev.azure.com/dnceng/public/_build/results?buildId=1872713&view=results

@TIHan
Copy link
Contributor Author

TIHan commented Jul 12, 2022

@BruceForstall JIT/Directed/shift/int64_r/int64_r.sh isn't failing anymore:

BEGIN EXECUTION
/datadisks/disk1/work/AA48093E/p/ildasm -raweh -unicode -out=int64_r.dasm.il int64_r.dll
/datadisks/disk1/work/AA48093E/p/ilasm -output=int64_r.asm.dll int64_r.dasm.il

Microsoft (R) .NET IL Assembler.  Version 7.0.0-ci
C
Assembling 'int64_r.dasm.il'  to EXE --> 'int64_r.asm.dll'
Source file is UNICODE

Assembled method ShiftTest.CL::.ctor
Assembled method ShiftTest.longTest::f1
Assembled method ShiftTest.longTest::f2
Assembled method ShiftTest.longTest::Main
Assembled method ShiftTest.longTest::.ctor
Assembled method ShiftTest.longTest::.cctor
Creating PE file

Emitting classes:
Class 1:	ShiftTest.CL
Class 2:	ShiftTest.VT
Class 3:	ShiftTest.longTest

Emitting fields and methods:
Global 	
Class 1	Fields: 1;	Methods: 1;	
Class 2	Fields: 1;	
Class 3	Fields: 1;	Methods: 5;	
Resolving local member refs: 35 -> 35 defs, 0 refs, 0 unresolved

Emitting events and properties:
Global 	
Class 1	
Class 2	
Class 3	
Resolving local member refs: 0 -> 0 defs, 0 refs, 0 unresolved
Writing PE file
Operation completed successfully
/datadisks/disk1/work/AA48093E/p/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false int64_r.asm.dll ''
The expected result of (0x7FFFFFFFFFFFFFFF>>8) is: 36028797018963967

The actual result for funciton argument is: 36028797018963967
The actual result for local variable is: 36028797018963967
The actual result for static field is: 36028797018963967
The actual result for array element is: 36028797018963967
The actual result for class member is: 36028797018963967
The actual result for valuestruct member is: 36028797018963967

The expected result of (0x1<<8) is: 256

The actual result for funciton argument is: 256
The actual result for local variable is: 256
The actual result for static field is: 256
The actual result for array element is: 256
The actual result for class member is: 256
The actual result for valuestruct member is: 256

PASSED
/datadisks/disk1/work/AA48093E/p/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false int64_r.dll ''
The expected result of (0x7FFFFFFFFFFFFFFF>>8) is: 36028797018963967

The actual result for funciton argument is: 36028797018963967
The actual result for local variable is: 36028797018963967
The actual result for static field is: 36028797018963967
The actual result for array element is: 36028797018963967
The actual result for class member is: 36028797018963967
The actual result for valuestruct member is: 36028797018963967

The expected result of (0x1<<8) is: 256

The actual result for funciton argument is: 256
The actual result for local variable is: 256
The actual result for static field is: 256
The actual result for array element is: 256
The actual result for class member is: 256
The actual result for valuestruct member is: 256

PASSED
Expected: 100
Actual: 100
END EXECUTION - PASSED
Test Harness Exitcode is : 0

The other failures are known.

@TIHan
Copy link
Contributor Author

TIHan commented Jul 12, 2022

@dotnet/jit-contrib needs another review, but CI shows that it fixes the unicode bit for linux

@TIHan TIHan merged commit 35f0230 into main Jul 14, 2022
@TIHan TIHan deleted the TIHan-patch-1 branch July 14, 2022 01:35
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants