ILASM - Disable fileversionpreservation test
#71972
Conversation
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsShould stop this from failing for now: #71919 ILASM does not support embedding or generating resource data; we would need to add that functionality. It used to exist, but it depended on
|
|
@dotnet/jit-contrib ready for review |
There was a problem hiding this comment.
You're disabling it for all configurations. You only need to disable it for ilasm round-trip testing.
Use IlasmRoundTripIncompatible. See https://github.com/dotnet/runtime/blob/main/docs/workflow/ci/disabling-tests.md and other test examples that use this.
Is this test failure happening now because the recent changes mean we're actually (finally) running the round-tripped dll?
ghost
added
the
needs-author-action
Yes. I'll correctly disable the test. |
ghost
removed
the
needs-author-action
…o disable roundtrip test for fileversionpreservation
TIHan
force-pushed
the
ilasm-test-disable-fileversionpreservation
branch
from
bbc901e
to
70ccd4f
Compare
|
@dotnet/jit-contrib ready for review again. I used |
ghost
locked as resolved and limited conversation to collaborators
Should stop this from failing for now: #71919
ILASM does not support embedding or generating resource data; we would need to add that functionality. It used to exist, but it depended on
CvtRes.exewhich the dotnet team does not own; which is the reason the resource embedding support was removed. See dotnet/coreclr#20818 and #11412