Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILASM - Allow EntryPoint methods to be on interfaces #71975

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Jul 11, 2022

Should resolve: #49998

Description

ILASM would error if an EntryPoint was on an interface. This PR should fix that as it is legal to do now.

Acceptance Criteria

  • Tests

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned TIHan Jul 11, 2022
@TIHan
Copy link
Contributor Author

TIHan commented Jul 11, 2022

/azp run runtime-coreclr ilasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Jul 11, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Should resolve: #49998

Description

ILASM would error if an EntryPoint was on an interface. This PR should fix that as it is legal to do now.

Acceptance Criteria

  • Tests
Author: TIHan
Assignees: TIHan
Labels:

area-ILTools-coreclr

Milestone: -

@TIHan
Copy link
Contributor Author

TIHan commented Jul 12, 2022

@dotnet/jit-contrib This is ready.

@TIHan TIHan merged commit de4dc66 into dotnet:main Jul 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILAsm errors when entrypoint method declared on an interface
3 participants