Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NuGet reference versions #72451

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

jakobbotsch
Copy link
Member

These references were still pulling in Newtonsoft.Json 9.0.1 causing
governance problems.

Also update a Microsoft.Build.Tasks.Core reference to use our defined
property for it.

These references were still pulling in Newtonsoft.Json 9.0.1 causing
governance problems.

Also update a Microsoft.Build.Tasks.Core reference to use our defined
property for it.
@ghost
Copy link

ghost commented Jul 19, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

These references were still pulling in Newtonsoft.Json 9.0.1 causing
governance problems.

Also update a Microsoft.Build.Tasks.Core reference to use our defined
property for it.

Author: jakobbotsch
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer
Copy link
Member

/azp run runtime

@ViktorHofer
Copy link
Member

CLI didn't trigger.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Please make sure that CI ran before merging.

@jakobbotsch
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch
Copy link
Member Author

Test failure looks like #69125

@jakobbotsch jakobbotsch merged commit 47974ff into dotnet:main Jul 20, 2022
@jakobbotsch jakobbotsch deleted the update-deps-newtonsoft branch July 20, 2022 08:13
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants