Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all pinvoke source generator attributes in aggressive trimming mode #72952

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

marek-safar
Copy link
Contributor

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Jul 27, 2022
@ghost ghost assigned marek-safar Jul 27, 2022
@ghost
Copy link

ghost commented Jul 27, 2022

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: marek-safar
Assignees: -
Labels:

linkable-framework

Milestone: -

@ghost
Copy link

ghost commented Jul 27, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: marek-safar
Assignees: marek-safar
Labels:

area-System.Runtime, linkable-framework

Milestone: -

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @AaronRobinsonMSFT to confirm these aren't needed for any purpose during execution.

@AaronRobinsonMSFT
Copy link
Member

LGTM, but @AaronRobinsonMSFT to confirm these aren't needed for any purpose during execution.

They have no use during execution. :shipit:

@marek-safar marek-safar merged commit a67c1ad into dotnet:main Aug 1, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants