-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix execution of ilverify tests in outerloop runs #73132
Conversation
/azp run runtime-coreclr outerloop |
Tagging subscribers to this area: @hoyosjs Issue DetailsAs @jkotas noticed in #73109, outerloop tests don't run the The pre-existing logic for determining active two-level test Thanks Tomas /cc @dotnet/runtime-infrastructure
|
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
The XUnitWrapper is failing to find the .cmd file to run the tests:
|
As JanK noticed in dotnet#73109, outerloop tests don't run the ilverify/ILVerificationTests.csproj test project. This is because the project is somewhat atypical in residing just one directory level beneath the test binary root folder; all other tests reside under at least two directory levels and the legacy XUnit wrapper generator reflects it so that each wrapper corresponds to a two-level directory subtree. The pre-existing logic for determining active two-level test directories was quite hacky and perf-costly; I probably accidentally removed the support for single-subfolder tests in one of my refactorings of the src/tests/build.proj script. This change fixes it and makes the construction of TestDirectories much more efficient as we no longer construct a Carthesian product of all tests and all two-level folder directories. Thanks Tomas
53955be
to
4602aa6
Compare
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
The only remaining failure is the timeout in the llvmfullaot tests that is known and hopefully about to be addressed by #73265, merging in. |
@trylek Thank you! |
As @jkotas noticed in #73109, outerloop tests don't run the
ilverify/ILVerificationTests.csproj test project. This is because
the project is somewhat atypical in residing just one directory
level beneath the test binary root folder; all other tests reside
under at least two directory levels and the legacy XUnit wrapper
generator reflects it so that each wrapper corresponds to
a two-level directory subtree.
The pre-existing logic for determining active two-level test
directories was quite hacky and perf-costly; I probably accidentally
removed the support for single-subfolder tests in one of my
refactorings of the src/tests/build.proj script. This change fixes
it and makes the construction of TestDirectories much more efficient
as we no longer construct a Carthesian product of all tests
times all two-level directories.
Thanks
Tomas
/cc @dotnet/runtime-infrastructure