Delete GTF_VAR_CAST
#74461
Merged
Delete GTF_VAR_CAST
#74461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIt is unused. Tighten an assert in the ref counter and relax one in VN. Fixes #74259.
|
It is unused. Tighten an assert in the ref counter.
SingleAccretion
force-pushed
the
Delete-GTF_VAR_CAST
branch
from
04aeb89
to
5f17108
Compare
|
@dotnet/jit-contrib |
|
Will rerun CI on this one. |
jakobbotsch
reviewed
Sep 21, 2022
Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
jakobbotsch
approved these changes
Sep 21, 2022
|
Failure looks like the same as #75990 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unused.
Tighten an assert in the ref counter and relax one in VN.
Diffs - we now contain more in-memory locals under bounds checks because they have the proper
INTtype. Also a nice TP win from downgrading thenoway_assertto an ordinaryassert.Fixes #74259.