Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [NotNullIfNotNull] to conversions from string to JsonNode. #74643

Merged
merged 1 commit into from
Aug 27, 2022

Conversation

teo-tsirpanis
Copy link
Contributor

No description provided.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 26, 2022
@ghost
Copy link

ghost commented Aug 26, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: teo-tsirpanis
Assignees: -
Labels:

area-System.Text.Json, new-api-needs-documentation

Milestone: -

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stephentoub stephentoub merged commit def885e into dotnet:main Aug 27, 2022
@teo-tsirpanis teo-tsirpanis deleted the jsonnodes-string-nullability branch September 23, 2022 16:02
@ghost ghost locked as resolved and limited conversation to collaborators Oct 23, 2022
@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants