Update il range in optOptimizeBoolsUpdateTrees

[En3Tho]

Possible fix for #49471

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Possible fix for #49471

So far I wasn't been able to repro this BasicBlock optimization. So leaving this as draft for now (and hope tests will catch something)

Author:	En3Tho
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[En3Tho]

For this kind of method IL range seems to be updated correctly

static int TestBasicBlocks(int x, int y)
    {
        if (x == 0 && y == 0)
        {
            return 0;
        }

        return 2;
    }

*************** Finishing PHASE Find loops
Trees after Find loops

-----------------------------------------------------------------------------------------------------------------------------------------
BBnum BBid ref try hnd preds           weight    lp [IL range]     [jump]      [EH region]         [flags]
-----------------------------------------------------------------------------------------------------------------------------------------
BB01 [0000]  1                             1       [000..003)-> BB04 ( cond )                     i 
BB02 [0001]  1       BB01                  0.50    [003..006)-> BB04 ( cond )                     i 
BB03 [0002]  1       BB02                  0.50    [006..008)        (return)                     i 
BB04 [0003]  2       BB01,BB02             0.50    [008..00A)        (return)                     i 
-----------------------------------------------------------------------------------------------------------------------------------------

=>

Before:

*************** Finishing PHASE Optimize bools
Trees after Optimize bools

-----------------------------------------------------------------------------------------------------------------------------------------
BBnum BBid ref try hnd preds           weight    lp [IL range]     [jump]      [EH region]         [flags]
-----------------------------------------------------------------------------------------------------------------------------------------
BB01 [0000]  1                             1       [000..003)-> BB04 ( cond )                     i 
BB03 [0002]  1       BB01                  0.50    [006..008)        (return)                     i 
BB04 [0003]  1       BB01                  0.50    [008..00A)        (return)                     i 
-----------------------------------------------------------------------------------------------------------------------------------------

After:

*************** Finishing PHASE Optimize bools
Trees after Optimize bools

-----------------------------------------------------------------------------------------------------------------------------------------
BBnum BBid ref try hnd preds           weight    lp [IL range]     [jump]      [EH region]         [flags]
-----------------------------------------------------------------------------------------------------------------------------------------
BB01 [0000]  1                             1       [000..006)-> BB04 ( cond )                     i 
BB03 [0002]  1       BB01                  0.50    [006..008)        (return)                     i 
BB04 [0003]  1       BB01                  0.50    [008..00A)        (return)                     i 
-----------------------------------------------------------------------------------------------------------------------------------------

[En3Tho]

Should an assert be added somewhere after OptimizeBools?
To check that basic blocks ranges are correctly updated

[JulieLeeMSFT]

Thanks @En3Tho for the PR. We are now busy with finishing up .NET 7. @EgorBo, Please review this community contribution.

[En3Tho]

Can someone review this please?

[EgorBo]

Sorry for the long delay, thanks for the contribution! Looks good to me, could you please check what it returns for:

static int TestBasicBlocks(int x, int y) => x == 0 && y == 0;

(the case with RETURN)

[En3Tho]

@EgorBo Thanks! I changed you example to

public static bool TestBasicBlocks2(int x, int y) => x == 0 && y == 0;

I hope you meant bool, not int.

With PR:

*************** Finishing PHASE Optimize bools
Trees after Optimize bools

-----------------------------------------------------------------------------------------------------------------------------------------
BBnum BBid ref try hnd preds           weight    lp [IL range]     [jump]      [EH region]         [flags]
-----------------------------------------------------------------------------------------------------------------------------------------
BB01 [0000]  1                             1       [000..00A)        (return)                     i 
-----------------------------------------------------------------------------------------------------------------------------------------

Without:

*************** Finishing PHASE Optimize bools
Trees after Optimize bools

-----------------------------------------------------------------------------------------------------------------------------------------
BBnum BBid ref try hnd preds           weight    lp [IL range]     [jump]      [EH region]         [flags]
-----------------------------------------------------------------------------------------------------------------------------------------
BB01 [0000]  1                             1       [000..003)        (return)                     i 
-----------------------------------------------------------------------------------------------------------------------------------------

It seems to be correctly updated to 000..00A

For example this is how it looks few phases before:

*************** Finishing PHASE Find loops
Trees after Find loops

-----------------------------------------------------------------------------------------------------------------------------------------
BBnum BBid ref try hnd preds           weight    lp [IL range]     [jump]      [EH region]         [flags]
-----------------------------------------------------------------------------------------------------------------------------------------
BB01 [0000]  1                             1       [000..003)-> BB03 ( cond )                     i 
BB02 [0001]  1       BB01                  0.50    [003..008)        (return)                     i 
BB03 [0002]  1       BB01                  0.50    [008..00A)        (return)                     i 
-----------------------------------------------------------------------------------------------------------------------------------------

[EgorBo]

Thanks for your contribution!