JIT: block copy/zero assertion gen for structs with exposed promoted … #75375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fields If a struct has an exposed field, we can't safely reason about is value in local assertion prop. Closes dotnet#75249.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details…fields If a struct has an exposed field, we can't safely reason about is value in local assertion prop. Closes #75249.
|
|
@jakobbotsch PTAL A few minor diffs expected. |
jakobbotsch
approved these changes
Sep 10, 2022
|
I had to retry the x86 spmi replay; it passed but failed with the duplicate artifacts issue. Monollvm AOT failure is unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fields
If a struct has an exposed field, we can't safely reason about is value in local assertion prop.
Closes #75249.