Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: don't try fetching fields of ref classes as SPMI extra queries #75500

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

AndyAyersMS
Copy link
Member

Enumeration of ref class fields requires walking up the type hierarchy. Since this is done in an optional query to extend the viability of an SPMI collection, skip for now.

Fixes #74968.

Enumeration of ref class fields requires walking up the type hierarchy.
Since this is done in an optional query to extend the viability of an
SPMI collection, skip for now.

Fixes dotnet#74968.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 13, 2022
@ghost ghost assigned AndyAyersMS Sep 13, 2022
@ghost
Copy link

ghost commented Sep 13, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Enumeration of ref class fields requires walking up the type hierarchy. Since this is done in an optional query to extend the viability of an SPMI collection, skip for now.

Fixes #74968.

Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS
Copy link
Member Author

@EgorBo PTAL
cc @dotnet/jit-contrib

@AndyAyersMS AndyAyersMS merged commit fb4772f into dotnet:main Sep 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

superpmi: failure to collect ObjectStackAllocationTests.dll
2 participants