Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up InteropServices.JavaScript project file #75962

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Sep 21, 2022

Nullable=enable is the default for source libraries.
The AnalyzerReference shouldn't be required as the library doesn't produce a package.

@ghost
Copy link

ghost commented Sep 21, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-System.Runtime.InteropServices

Milestone: -

@pavelsavara
Copy link
Member

Partial method 'JavaScriptImports.GetTypeOfProperty(JSObject, string)' must have an implementation part because it has accessibility modifiers. is caused by removal of AnalyzerReference

@ViktorHofer
Copy link
Member Author

I see. So this library is actually consuming its own source generator. Fixed that.

@ViktorHofer
Copy link
Member Author

@pavelsavara can you please take another look? :)

@ViktorHofer ViktorHofer merged commit c50d5e0 into main Sep 22, 2022
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-2 branch September 22, 2022 09:44
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants