Process primitives in local morph #76155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsOne more step towards Some small improvements and some smaller regressions from copy propagation.
|
SingleAccretion
force-pushed
the
LclMorph-Primitives
branch
2 times, most recently
from
638353d
to
e9b0dee
Compare
Only for RETURN users for now.
We should really delete TYP_BOOL.
The code isn't actually set up for this. No diffs.
SingleAccretion
force-pushed
the
LclMorph-Primitives
branch
from
031a398
to
d2580c8
Compare
SingleAccretion
force-pushed
the
LclMorph-Primitives
branch
from
d2580c8
to
007f156
Compare
Closed
|
@dotnet/jit-contrib |
AndyAyersMS
approved these changes
Oct 2, 2022
| @@ -3835,37 +3835,16 @@ GenTree* Compiler::optAssertionProp_LclFld(ASSERT_VALARG_TP assertions, GenTreeL | |||
| break; | |||
| } | |||
|
|
|||
| // See if the variable is equal to another variable or a constant. | |||
| // See if the variable is equal to another variable. | |||
There was a problem hiding this comment.
Strange, I thought I had already removed this.
Also fgMorphTree already iterates, assuming there are opportunities to chain assertions.
|
Thank you for your continued work on the jit. |
jkotas
added a commit
to jkotas/runtime
that referenced
this pull request
Oct 5, 2022
This reverts commit ca6fb31.
This was referenced Oct 6, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more step towards
ADDRdeletion.Some small improvements and some smaller regressions from copy propagation. The regression in the tests collection is large because it is duplicated across many (generated) HWI tests.