Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JIT] X64/ARM64 - CAST removals for small types on ADD, SUB, MUL, AND, OR, XOR, NOT, NEG #77874

Merged
merged 71 commits into from
Jan 31, 2023
Merged

[JIT] X64/ARM64 - CAST removals for small types on ADD, SUB, MUL, AND, OR, XOR, NOT, NEG #77874

merged 71 commits into from
Jan 31, 2023

Commits on Nov 4, 2022

  1. Trying to optimize Add

    @TIHan
    TIHan committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    f6bb7d4 View commit details
    Browse the repository at this point in the history

  2. Trying to optimize Add

    @TIHan
    TIHan committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    81a1bcb View commit details
    Browse the repository at this point in the history

  3. Trying to optimize Add

    @TIHan
    TIHan committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    1b29b47 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into add-opt-x64

    @TIHan
    TIHan committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    2599997 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2022

  1. Added IntAdd disasm tests. Expanded cast removals to all arithmetic a… 

    …nd neg/not.
    @TIHan
    TIHan committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    5e3741c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into add-opt-x64

    @TIHan
    TIHan committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    371ca7d View commit details
    Browse the repository at this point in the history

  3. Checked unsigned

    @TIHan
    TIHan committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    2a43021 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Limit arithmetic opt

    @TIHan
    TIHan committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    5428df9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add-opt-x64' of https://github.com/TIHan/runtime into a… 

    …dd-opt-x64
    @TIHan
    TIHan committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    ac58639 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Merge remote-tracking branch 'upstream/main' into add-opt-x64

    @TIHan
    TIHan committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    7badcc0 View commit details
    Browse the repository at this point in the history

  2. Moving optimization to Morph

    @TIHan
    TIHan committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    6d85c1a View commit details
    Browse the repository at this point in the history

  3. Cleanup. Allow more opts.

    @TIHan
    TIHan committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    02dbb22 View commit details
    Browse the repository at this point in the history

  4. Fix build

    @TIHan
    TIHan committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    779dd21 View commit details
    Browse the repository at this point in the history

  5. More opts

    @TIHan
    TIHan committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    a263faa View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Added regression test. Allowing all arithmetic ops. Only do transform… 

    …ation if the op is a local
    @TIHan
    TIHan committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    f7c8b68 View commit details
    Browse the repository at this point in the history

  2. Do not do optimization for unsigned ops

    @TIHan
    TIHan committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    3eba2fa View commit details
    Browse the repository at this point in the history

  3. Added more division test cases

    @TIHan
    TIHan committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    ec3dcda View commit details
    Browse the repository at this point in the history

  4. Fixed test. Checking overflows on cast. Comparing actual types proper… 

    …ly on the CastOp.
    @TIHan
    TIHan committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    183d570 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Added flag

    @TIHan
    TIHan committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    4378c1b View commit details
    Browse the repository at this point in the history

  2. Remove flag

    @TIHan
    TIHan committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    4a0b63d View commit details
    Browse the repository at this point in the history

  3. Formatting

    @TIHan
    TIHan committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    73fbc61 View commit details
    Browse the repository at this point in the history

  4. Revert minor change

    @TIHan
    TIHan committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    38ec57f View commit details
    Browse the repository at this point in the history

  5. Removed ClearRegOptionalAndContained

    @TIHan
    TIHan committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    343badf View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Merge remote-tracking branch 'upstream/main' into add-opt-x64

    @TIHan
    TIHan committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    2e5c716 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2022

  1. Merge remote-tracking branch 'upstream/main' into add-opt-x64

    @TIHan
    TIHan committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    e417b63 View commit details
    Browse the repository at this point in the history

  2. Trying out lowering

    @TIHan
    TIHan committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    95840b2 View commit details
    Browse the repository at this point in the history

  3. Expanded lowering cast removal to arm

    @TIHan
    TIHan committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    1c2e139 View commit details
    Browse the repository at this point in the history

  4. Added regression test

    @TIHan
    TIHan committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    49341e6 View commit details
    Browse the repository at this point in the history

  5. Do not use disasm checks for these tests

    @TIHan
    TIHan committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    60f48ba View commit details
    Browse the repository at this point in the history

  6. Update lower.cpp

    @TIHan
    TIHan committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    b267aa5 View commit details
    Browse the repository at this point in the history

  7. Fixing

    @TIHan
    TIHan committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    caefb4a View commit details
    Browse the repository at this point in the history

  8. For JCC, do not change castOp type if it is a bool

    @TIHan
    TIHan committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    e226f30 View commit details
    Browse the repository at this point in the history

  9. Added more regression tests made from Fuzzlyn. Reverted minor cast ch… 

    …ange. Changing type for GT_LCL_VAR if it is appropriate for OptimizeConstCompare.
    @TIHan
    TIHan committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    84ae5a7 View commit details
    Browse the repository at this point in the history

  10. Remove Morph impl as we are not favoring Lowering. Do not change var … 

    …type on arm.
    @TIHan
    TIHan committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    937596b View commit details
    Browse the repository at this point in the history

  11. Formatting

    @TIHan
    TIHan committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    6cc95ca View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Re-arranging regression tests. Some comments. Some And and Or disasm … 

    …tests.
    @TIHan
    TIHan committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    e5c9b93 View commit details
    Browse the repository at this point in the history

  2. Fixed a few minor regressions

    @TIHan
    TIHan committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    966df08 View commit details
    Browse the repository at this point in the history

  3. minor change

    @TIHan
    TIHan committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    94411b5 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into add-opt-x64

    @TIHan
    TIHan committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    4cb4d6d View commit details
    Browse the repository at this point in the history

  5. Moving optimization to simple lowering

    @TIHan
    TIHan committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    3ec0f0d View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Moving back to morph

    @TIHan
    TIHan committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    cb1983c View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Add print for implicit cast

    @TIHan
    TIHan committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    6f71cff View commit details
    Browse the repository at this point in the history

  2. Do it a little earlier

    @TIHan
    TIHan committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    ca60055 View commit details
    Browse the repository at this point in the history

  3. Mark as do-not-cse to prevent the CAST from being removed on assignment

    @TIHan
    TIHan committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    e445092 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Fix test

    @TIHan
    TIHan committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    4b9d344 View commit details
    Browse the repository at this point in the history

  2. Remove do-not-set cse

    @TIHan
    TIHan committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    7022968 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Moving optimization to simple lowering again for correctness

    @TIHan
    TIHan committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    ec5088f View commit details
    Browse the repository at this point in the history

  2. Disable some of the regression tests for mono

    @TIHan
    TIHan committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    62938ba View commit details
    Browse the repository at this point in the history

  3. Fixing IntOr disasm test

    @TIHan
    TIHan committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    e90ce88 View commit details
    Browse the repository at this point in the history

  4. Formatting, fixing test again

    @TIHan
    TIHan committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    769d1c1 View commit details
    Browse the repository at this point in the history

  5. Smaller size operators can contain/reg-optional operands that are larger

    @TIHan
    TIHan committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    6903869 View commit details
    Browse the repository at this point in the history

  6. Formatting

    @TIHan
    TIHan committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    de34d34 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Added subtract tests

    @TIHan
    TIHan committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    f1ef6f3 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Update IntAnd.cs

    @TIHan
    TIHan committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    38386d5 View commit details
    Browse the repository at this point in the history

  2. Update IntAnd.cs

    @TIHan
    TIHan committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    f34f943 View commit details
    Browse the repository at this point in the history

  3. Update IntOr.cs

    @TIHan
    TIHan committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    232fe85 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Update IntSubtract.cs

    @TIHan
    TIHan committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    476143e View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Added IsContainableMemoryOpSize

    @TIHan
    TIHan committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    e0d49b3 View commit details
    Browse the repository at this point in the history

  2. Merged

    @TIHan
    TIHan committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    21f3a8b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'add-opt-x64' of https://github.com/TIHan/runtime into a… 

    …dd-opt-x64
    @TIHan
    TIHan committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    aad9ca3 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Merge remote-tracking branch 'upstream/main' into add-opt-x64

    @TIHan
    TIHan committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    37fc2fb View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Removed unnecessary code.

    @TIHan
    TIHan committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    23427f6 View commit details
    Browse the repository at this point in the history

  2. Update IntAnd.cs

    @TIHan
    TIHan committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    520be33 View commit details
    Browse the repository at this point in the history

  3. Update Regression1.cs

    @TIHan
    TIHan committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    7cac5e2 View commit details
    Browse the repository at this point in the history

  4. Update Regression1.cs

    @TIHan
    TIHan committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    c6a31fe View commit details
    Browse the repository at this point in the history

  5. Update Regression2.cs

    @TIHan
    TIHan committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    2fbe829 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2023

  1. Update Regression2.cs

    @TIHan
    TIHan committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    3384759 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Merge remote-tracking branch 'upstream/main' into add-opt-x64

    @TIHan
    TIHan committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    2ea70d4 View commit details
    Browse the repository at this point in the history

  2. Disable if optimizations are disabled

    @TIHan
    TIHan committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    40b59c2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'add-opt-x64' of https://github.com/TIHan/runtime into a… 

    …dd-opt-x64
    @TIHan
    TIHan committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    051d513 View commit details
    Browse the repository at this point in the history

  4. Merge

    @TIHan
    TIHan committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    25784fb View commit details
    Browse the repository at this point in the history