Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit manifest for NativeRuntimeEventSource #78213

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

davmason
Copy link
Member

Fixes #77014

The managed NativeRuntimeEventSource is conceptually an extension of the native coreclr provider, we should not emit the manifest for it since they are very large and there could be many dotnet processes running.

@davmason davmason added this to the 8.0.0 milestone Nov 11, 2022
@davmason davmason requested review from brianrob and a team November 11, 2022 11:37
@davmason davmason self-assigned this Nov 11, 2022
@davmason davmason merged commit 653be13 into dotnet:main Nov 13, 2022
davmason added a commit to davmason/runtime that referenced this pull request Nov 20, 2022
davmason added a commit to davmason/runtime that referenced this pull request Nov 20, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventSource::SendManifest causes lost events which result in unmergable ETL files
3 participants