-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ASCII strings in source files #78265
Conversation
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsThis is to align with coding style pt. 16. Used https://gist.github.com/am11/f35c61783ad7b7c304b3d6e8bd1dcab4 as: git config core.quotepath off
git ls-files ':/src/*cs' ':/src/*vb' ':/src/*fs' | xargs -I{} conv {} {} followed by some manual fixes.
|
18b1779
to
a1f1a74
Compare
How do we feel about BOMs - should we remove them all? I guess some would just come back, so it might just be making unnecessary diffs. |
Yes, there are plenty of files with BOM (1514 files with There are two BOM related changes in this PR delta:
|
src/libraries/System.Private.CoreLib/src/System/SpanHelpers.Byte.cs
Outdated
Show resolved
Hide resolved
e6221f9
to
491957e
Compare
491957e
to
f6eb111
Compare
841392a
to
b4f43d1
Compare
@danmoseley, was there any other comment / concern? |
Thanks for the attention to detail on this @am11 (including making author name/email comments consistent). I've spot-checked the characters throughout and all was matching up. Thanks for sharing how you approached this too; that was helpful. I'm rerunning the failed checks for good measure... |
Thanks @am11. This definitely has made our tests more robust. The case I was concerned about is tests that have a magic input and end up verifying it matches the output. If those get garbelized probably nobody would have noticed. |
Commit migrated from dotnet/runtime@10e929a
This is to align with coding style pt. 16.
Used https://gist.github.com/am11/f35c61783ad7b7c304b3d6e8bd1dcab4 as:
followed by some manual fixes.