Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullable annotations in ITypeDescriptorContext #78287

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 13, 2022
@ghost
Copy link

ghost commented Nov 13, 2022

Tagging subscribers to this area: @dotnet/area-system-componentmodel
See info in area-owners.md if you want to be subscribed.

Issue Details

According to:
https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.itypedescriptorcontext.container?view=net-7.0
https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.itypedescriptorcontext.instance?view=net-7.0
https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.itypedescriptorcontext.propertydescriptor?view=net-7.0
these can be null.
I bumped into this problem while annotating GridEntry in WinForms repository.
https://github.com/dotnet/winforms/blob/ecc6966e1eb76d7c9921638137e058f2243d7dd9/src/System.Windows.Forms/src/System/Windows/Forms/PropertyGridInternal/GridEntry.cs#L170

Author: gpetrou
Assignees: -
Labels:

area-System.ComponentModel, new-api-needs-documentation, community-contribution

Milestone: -

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephentoub stephentoub added breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. and removed new-api-needs-documentation labels Nov 13, 2022
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Nov 13, 2022
@ghost

This comment was marked as resolved.

@stephentoub
Copy link
Member

@jeffhandley, I assume we'll do a single breaking change roll-up page again for all nullable annotation differences that would lead to new warnings?

@stephentoub stephentoub merged commit cc712fd into dotnet:main Nov 13, 2022
@gpetrou gpetrou deleted the ITypeDescriptorContext branch November 13, 2022 15:39
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2022
@jeffhandley
Copy link
Member

@stephentoub Thanks for checking on this. We will not do a single roll-up doc issue for nullable annotation changes, as that didn't work out great for doc creation tracking. The changes might all get rolled up into a single doc, but we need to file individual issues.

I created dotnet/docs#33225 for this one.

@jeffhandley jeffhandley removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.ComponentModel breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants