Fix typos #79136
Fix typos #79136
Conversation
am11
requested review from
marek-safar,
thaystg,
lambdageek,
vargaz and
SamMonoRT
as code owners
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsAlso cleaned up trailing whitespaces in the changeset files.
|
| @@ -14,7 +14,7 @@ namespace System.ComponentModel.Composition.Hosting | |||
| /// queryable state along with a sequence of actions necessary to complete the state when | |||
| /// the atomicComposition is no longer in danger of being rolled back. State is completed or | |||
| /// rolled back when the atomicComposition is disposed, depending on the state of the | |||
| /// CompleteOnDipose property which defaults to false. The using(...) pattern in C# is a | |||
| /// CompleteOnDispose property which defaults to false. The using(...) pattern in C# is a | |||
There was a problem hiding this comment.
There is not such property (even in the initial MEF1 port a6f350f).
|
Another frequent typo is in System.Threading.Tasks.TaskCanceledException where cancelled is always spelled with one "L", including in error messages. An example instance is: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Threading.Tasks/ref/System.Threading.Tasks.Forwards.cs#L30 |
This type name is a public contract. We don't change public contracts when fixing typos in bulk. BTW, both spellings are correct:
and here are some quick stats which show that this repo favors single L spelling (though both are in use): # count occurrences: 'cancelled' vs. 'canceled'
$ git grep -i cancelled | wc -l
580
$ git grep -i canceled | wc -l
4477 |
am11
force-pushed
the
feature/meta/fix-typos
branch
from
3706149
to
140fa72
Compare
|
CI failures are unrelated to changes:
|
Commit migrated from dotnet/runtime@3855a99
ghost
locked as resolved and limited conversation to collaborators
Also cleaned up trailing whitespaces in the changeset files.