Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in fixer on certain invalid patterns #80007

Merged
merged 10 commits into from
Jan 5, 2023
Merged

Fix crash in fixer on certain invalid patterns #80007

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c53c3c1
Add test
danmoseley Dec 28, 2022
c097c9d
Fix
danmoseley Dec 28, 2022
243fe64
Tweak strings
danmoseley Dec 28, 2022
4d421a7
remove inadvertent test
danmoseley Dec 28, 2022
2996b4c
Improve condition
danmoseley Dec 28, 2022
5acf490
more strings
danmoseley Dec 30, 2022
73a356e
do not offer fix
danmoseley Jan 3, 2023
118b805
comment
danmoseley Jan 4, 2023
ad42ae3
Merge branch 'main' into fixanalyzer1
danmoseley Jan 5, 2023
0effa01
Update src/libraries/System.Text.RegularExpressions/gen/UpgradeToGene…
buyaa-n Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve condition
  • Loading branch information
@danmoseley
danmoseley committed Dec 28, 2022
commit 2996b4ceaba7b3c5576143e2a26ac543fd5e63a4
2 changes: 1 addition & 1 deletion ...libraries/System.Text.RegularExpressions/tests/FunctionalTests/CSharpCodeFixVerifier`2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public static async Task VerifyCodeFixAsync(string source, string fixedSource, R
// but be unable to make the fix when requested.
// Such test cases need to indicate that an iteration is expected
// even though no fix is made.
if (expectedNumberOfIterations > 0)
if (expectedNumberOfIterations != -1)
{
test.NumberOfIncrementalIterations = expectedNumberOfIterations;
}
Expand Down