Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the performance of ConditionalWeakTable.TryGetValue #80059

Merged
merged 17 commits into from
Jan 5, 2023
Merged

Improve the performance of ConditionalWeakTable.TryGetValue #80059

merged 17 commits into from
Jan 5, 2023

Commits on Dec 30, 2022

  1. [NativeAOT] Fix Objective-C reference tracking 

    Fixes dotnet#80032
    @AustinWise
    AustinWise committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    bd618d4 View commit details
    Browse the repository at this point in the history

  2. Move implementation-specific comment out of public doc comment

    @AustinWise
    AustinWise committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    ce38802 View commit details
    Browse the repository at this point in the history

  3. Duplicate code for TryGetHashCode implementations.

    @AustinWise
    AustinWise committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    9967b1f View commit details
    Browse the repository at this point in the history

  4. Replace comments with a passing test.

    @AustinWise
    AustinWise committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    07bb690 View commit details
    Browse the repository at this point in the history

  5. Add moke test for restricted callouts.

    @AustinWise
    AustinWise committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    6a13d23 View commit details
    Browse the repository at this point in the history

  6. Remove TryGetHashCode from Mono 

    It does not guarantee that hash codes are non-zero.
    @AustinWise
    AustinWise committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    d9a6dc2 View commit details
    Browse the repository at this point in the history

  7. Update src/tests/Interop/ObjectiveC/ObjectiveCMarshalAPI/Program.cs 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @AustinWise @jkotas
    AustinWise and jkotas authored Dec 30, 2022
    Configuration menu
    Copy the full SHA
    cd22146 View commit details
    Browse the repository at this point in the history

  8. Update src/libraries/System.Private.CoreLib/src/System/Runtime/Compil… 

    …erServices/ConditionalWeakTable.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @AustinWise @jkotas
    AustinWise and jkotas authored Dec 30, 2022
    Configuration menu
    Copy the full SHA
    2131f4d View commit details
    Browse the repository at this point in the history

  9. Revert "Add moke test for restricted callouts." 

    This reverts commit 6a13d23.
    @AustinWise
    AustinWise committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    129eee0 View commit details
    Browse the repository at this point in the history

  10. Add test coverage for untracked objective objects.

    @AustinWise
    AustinWise committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    e81000f View commit details
    Browse the repository at this point in the history

  11. Spelling

    @AustinWise
    AustinWise committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    2eaed50 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2022

  1. Implement RuntimeHelpers.TryGetHashCode for Mono

    @AustinWise
    AustinWise committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    1ccbe61 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2023

  1. Remove unneeded MONO_COMPONENT_API

    @AustinWise
    AustinWise committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    84d8c40 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2023

  1. Remove Mono intrinsic for InternalGetHashCode 

    This is dead code because this method no longer lives on
System.Object.
    @AustinWise
    AustinWise committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    58f3667 View commit details
    Browse the repository at this point in the history

  2. Move interpreter transforms to correct class.

    @AustinWise
    AustinWise committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    1d94c9c View commit details
    Browse the repository at this point in the history

  3. Rename and move icall to match convention.

    @AustinWise
    AustinWise committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    93f22e1 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Merge remote-tracking branch 'origin/main' into austin/TryGetHashCode

    @AustinWise
    AustinWise committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    4d65fa4 View commit details
    Browse the repository at this point in the history