[main] Update dependencies from dotnet/arcade #80234

dotnet-maestro · 2023-01-05T13:18:49Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
Build: 20230109.1
Date Produced: January 9, 2023 2:51:20 PM UTC
Commit: d360f5e4d22cdc673601d6cc60284ced948706ae
Branch: refs/heads/main

Updates:
- Microsoft.DotNet.Arcade.Sdk: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.Build.Tasks.Archives: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.Build.Tasks.Feed: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.Build.Tasks.Installers: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.Build.Tasks.Packaging: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.Build.Tasks.TargetFramework: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.Build.Tasks.Templating: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.Build.Tasks.Workloads: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.CodeAnalysis: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.GenAPI: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.GenFacades: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.Helix.Sdk: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.PackageTesting: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.RemoteExecutor: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.SharedFramework.Sdk: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.VersionTools.Tasks: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1
- Microsoft.DotNet.XUnitConsoleRunner: from 2.5.1-beta.23053.5 to 2.5.1-beta.23059.1
- Microsoft.DotNet.XUnitExtensions: from 8.0.0-beta.23053.5 to 8.0.0-beta.23059.1

…104.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23053.5 -> To Version 8.0.0-beta.23054.2

lewing · 2023-01-05T15:31:19Z

@radical can you take a look at the wbt failures?

radical · 2023-01-05T16:35:29Z

Should be fixed by #80241 .

…105.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23053.5 -> To Version 8.0.0-beta.23055.2

…105.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23053.5 -> To Version 8.0.0-beta.23055.3

…106.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23053.5 -> To Version 8.0.0-beta.23056.4

ViktorHofer · 2023-01-09T09:32:53Z

cc @vitek-karas @agocke @sbomer

EDIT: The error hides the actual projects that cause the failures. Here's one:

C:\Program Files\dotnet\sdk\8.0.100-alpha.1.23055.1\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1195: Unable to optimize assemblies for size: a valid runtime package was not found. Either set the PublishTrimmed property to false, or use a supported target framework when publishing. [C:\git\runtime2\src\libraries\Microsoft.Extensions.DependencyInjection.Abstractions\src\Microsoft.Extensions.DependencyInjection.Abstractions.csproj]

I think this is now happening because illink.targets set IsTrimming to true and the SDK now also reads from that property to set _IsTrimmingEnabled.

EDIT 2:
I just pushed a commit that explicitly sets _IsTrimmingEnabled to false in illink.targets to not use the linker functionality from the SDK. The changes that introduced this behavior are dotnet/sdk#29441 and #65870. Presumably this is happening in runtime because we reference the linker package explicitly but the SDK now restores that via the ProcessFrameworkReferences target.

…108.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23053.5 -> To Version 8.0.0-beta.23058.1

`/__w/1/s/src/mono/wasm/host/WebServerStartup.cs(94,17): error ASP0019: Use IHeaderDictionary.Append or the indexer to append or set headers. IDictionary.Add will throw an ArgumentException when attempting to add a duplicate key. [/__w/1/s/src/mono/wasm/host/WasmAppHost.csproj] `

radical · 2023-01-09T18:05:09Z

I fixes the asp.net analyzer warning. But the remaining ones looks odd:

This looks wrong:

/__w/1/s/src/mono/wasm/host/Options.cs(456,13):
  error CA1512: Use 'ArgumentOutOfRangeException.ThrowIfNegative' instead of explicitly throwing a new exception instance [/__w/1/s/src/mono/wasm/host/WasmAppHost.csproj]

runtime/src/mono/wasm/host/Options.cs

Lines 455 to 459 in 10039ab

    
           { 
        
               if (prototype == null) 
        
                   throw new ArgumentNullException(nameof(prototype)); 
        
               if (prototype.Length == 0) 
        
                   throw new ArgumentException("Cannot be the empty string.", nameof(prototype));

This one might have the line number wrong?

/__w/1/s/src/mono/wasm/host/Options.cs(345,13):
  error CA1512: Use 'ArgumentOutOfRangeException.ThrowIfGreaterThanOrEqual' instead of explicitly throwing a new exception instance [/__w/1/s/src/mono/wasm/host/WasmAppHost.csproj]

runtime/src/mono/wasm/host/Options.cs

Lines 344 to 347 in 10039ab

    
           if (c.Option == null) 
        
               throw new InvalidOperationException("OptionContext.Option is null."); 
        
           if (index >= c.Option.MaxValueCount) 
        
               throw new ArgumentOutOfRangeException(nameof(index));

cc @stephentoub

…82-439c-94c4-8efff33d6ccd

radical · 2023-01-09T18:10:21Z

I'll fix, ignoring the line numbers in the errors.

radical · 2023-01-09T18:11:38Z

Ignore me. I was missing a commit off the top!

ViktorHofer · 2023-01-09T19:25:39Z

@radical I think your fix was incomplete:

src/mono/wasm/host/Options.cs(345,41): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'other' of 'ArgumentOutOfRangeException.ThrowIfGreaterThanOrEqual(T, T, string?)'

radical · 2023-01-09T19:26:54Z

@radical I think your fix was incomplete:

src/mono/wasm/host/Options.cs(345,41): error CS7036: (NETCORE_ENGINEERING_TELEMETRY=Build) There is no argument given that corresponds to the required parameter 'other' of 'ArgumentOutOfRangeException.ThrowIfGreaterThanOrEqual(T, T, string?)'

lol forgot to commit it 😬

…109.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23053.5 -> To Version 8.0.0-beta.23059.1

ViktorHofer · 2023-01-11T09:10:06Z

@vitek-karas @tlakollo @agocke can you please take a look at the linker test failures? I tried to resolve them but failed because of lacking domain knowledge.

ViktorHofer · 2023-01-11T14:17:53Z

@MichalStrehovsky can you please take a look at the NativeAOT failure. This PR updates the used SDK to an 8.0 version. Example failure:

 Generating native code
  Failed to create CoreCLR, HRESULT: 0x80131524
/Users/runner/work/1/s/artifacts/bin/coreclr/OSX.x64.Debug/build/Microsoft.NETCore.Native.targets(281,5): error MSB3073: The command ""/Users/runner/work/1/s/artifacts/bin/coreclr/OSX.x64.Debug/ilc-published/ilc" @"/Users/runner/work/1/s/artifacts/obj/coreclr/crossgen2/x64/Release/native/crossgen2.ilc.rsp"" exited with code 137. [/Users/runner/work/1/s/src/coreclr/tools/aot/crossgen2/crossgen2.csproj]
##[error]artifacts/bin/coreclr/OSX.x64.Debug/build/Microsoft.NETCore.Native.targets(281,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/Users/runner/work/1/s/artifacts/bin/coreclr/OSX.x64.Debug/ilc-published/ilc" @"/Users/runner/work/1/s/artifacts/obj/coreclr/crossgen2/x64/Release/native/crossgen2.ilc.rsp"" exited with code 137.

The analyzer tests download a ref package, but its version must at least roughly match the version used to run the tests. Since this updates the SDK to 8.0, update the tests to pick some 8.0 ref package. Also the new compiler produces two new warnings in one case, so baselined those in the test.

vitek-karas · 2023-01-11T15:34:01Z

@tlakollo could you please review the changes I made to fix the illink tests in 003edf1 ?

ViktorHofer · 2023-01-11T15:51:40Z

@sbomer I fixed one of the ILCompiler failures by setting AotRuntimePackageLoadedViaSDK in our linker test assemblies (see my latest commit). Can you please take a look?

Now that ILCompiler is always referenced via a PackageReference, it looks to me that the AotRuntimePackageLoadedViaSDK switch in ILCompiler.SingleEntry.targets is dead-code outside of dotnet/runtime. Should that be changed somehow?

…s instead of spaces

tlakollo · 2023-01-11T19:30:03Z

@tlakollo could you please review the changes I made to fix the illink tests in 003edf1 ?

I think is weird to have the ref assembly in 8 set to a specific version, but it does not matter much, because there is an issue to generate a more appropriate fix, so looks great :D

"Failed to create CoreCLR, HRESULT: 0x80131524" during runtime test ILC invocation. Might be fixed with 6c0c96c

ViktorHofer · 2023-01-11T20:55:52Z

Thanks to @janvorli's help the NativeAOT failures are resolved. The propagated SDK doesn't include a fix for a single-file bug. We were quite unlucky as we missed that commit just by a few hours during dependency flow from runtime to sdk.

I just updated the SDK to the latest available one and that fixed the issue. I will probably also update the SDK in the arcade repo.

TL;DR: We found a severe issue with the previous chosen SDK that impacts single file applications that results in a `Failed to create CoreCLR, HRESULT: 0x80131524` error. Upgrading to `8.0.100-alpha.1.23061.8` which contains the necessary runtime fix: dotnet/runtime@6c0c96c. See dotnet/runtime#80234 (comment) for more details

* Upgrade SDK to 8.0.100-alpha.1.23061.8 TL;DR: We found a severe issue with the previous chosen SDK that impacts single file applications that results in a `Failed to create CoreCLR, HRESULT: 0x80131524` error. Upgrading to `8.0.100-alpha.1.23061.8` which contains the necessary runtime fix: dotnet/runtime@6c0c96c. See dotnet/runtime#80234 (comment) for more details * Update DotNetCli.props

ViktorHofer · 2023-01-12T12:45:38Z

Test failure is #80543

dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Jan 5, 2023

build-analysis bot mentioned this pull request Jan 5, 2023

Tracking issue for CI build timeouts #76454

Closed

dotnet-maestro bot added 3 commits January 6, 2023 13:16

ViktorHofer added 2 commits January 9, 2023 12:03

React to SDK change around linking

557b0aa

Update NetCoreAppToolCurrent to net8.0

52f4937

ViktorHofer requested a review from marek-safar as a code owner January 9, 2023 12:25

ViktorHofer and others added 3 commits January 9, 2023 13:27

Upgrade aspnetcoretoolcurrent as well

9b623ae

radical requested review from lewing and pavelsavara as code owners January 9, 2023 17:50

Merge remote-tracking branch 'origin/main' into darc-main-aab430d2-d9…

08e6984

…82-439c-94c4-8efff33d6ccd

Fix CA1512 analyzer warnings

8342ded

pavelsavara approved these changes Jan 9, 2023

View reviewed changes

fix

11b736e

ViktorHofer and others added 2 commits January 10, 2023 12:18

React to aspnetcore analyzers

1fea7d7

This was referenced Jan 10, 2023

Tracking issue for CI build failure "Installing openssl@3 has failed!" #80428

Closed

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

ViktorHofer requested a review from sbomer as a code owner January 11, 2023 08:01

Update hardcoded linker tfm

978266d

Fix ILLinker tests on NativeAOT

62d241c

ViktorHofer mentioned this pull request Jan 11, 2023

[main] Update dependencies from 9 repositories #80429

Merged

Resolve analyzer warning in MonoLinkerTestsCasesExpectations

43b4d2c

ViktorHofer mentioned this pull request Jan 11, 2023

[main] Update dependencies from dotnet/arcade #80492

Closed

ViktorHofer and others added 3 commits January 11, 2023 18:32

Upgrade xunit runner tfm

38f62f6

Delete dead property

9dc60a2

In NativeAOT common files with ILLink have ILLink format, meaning tab…

ec5f16b

…s instead of spaces

Upgrade SDK because of "Failed to create CoreCLR"

562cac4

"Failed to create CoreCLR, HRESULT: 0x80131524" during runtime test ILC invocation. Might be fixed with 6c0c96c

ViktorHofer approved these changes Jan 11, 2023

View reviewed changes

ViktorHofer mentioned this pull request Jan 11, 2023

Upgrade SDK to 8.0.100-alpha.1.23061.8 dotnet/arcade#12181

Merged

1 task

Update macOS version target triple

dbc28a7

ViktorHofer mentioned this pull request Jan 12, 2023

[main] Update dependencies from dotnet/sdk dotnet/installer#15228

Merged

ViktorHofer merged commit a40d411 into main Jan 12, 2023

ViktorHofer deleted the darc-main-aab430d2-d982-439c-94c4-8efff33d6ccd branch January 12, 2023 14:00

jakobbotsch mentioned this pull request Jan 13, 2023

Latest dotnet --info no longer includes RID or Platform dotnet/jitutils#366

Closed

JamesNK mentioned this pull request Jan 19, 2023

Trimming issue workaround in .NET 8 grpc/grpc-dotnet#2022

Merged

AndyAyersMS mentioned this pull request Jan 25, 2023

Test failure JIT\\opt\\ObjectStackAllocation\\ObjectStackAllocationTests\\ObjectStackAllocationTests.cmd #81103

Closed

ghost locked as resolved and limited conversation to collaborators Feb 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/arcade #80234

[main] Update dependencies from dotnet/arcade #80234

dotnet-maestro bot commented Jan 5, 2023 •

edited

Loading

lewing commented Jan 5, 2023

radical commented Jan 5, 2023

ViktorHofer commented Jan 9, 2023 •

edited

Loading

radical commented Jan 9, 2023 •

edited

Loading

radical commented Jan 9, 2023

radical commented Jan 9, 2023

ViktorHofer commented Jan 9, 2023

radical commented Jan 9, 2023

ViktorHofer commented Jan 11, 2023

ViktorHofer commented Jan 11, 2023

vitek-karas commented Jan 11, 2023

ViktorHofer commented Jan 11, 2023

tlakollo commented Jan 11, 2023

ViktorHofer commented Jan 11, 2023

ViktorHofer commented Jan 12, 2023

[main] Update dependencies from dotnet/arcade #80234

[main] Update dependencies from dotnet/arcade #80234

Conversation

dotnet-maestro bot commented Jan 5, 2023 • edited Loading

From https://github.com/dotnet/arcade

lewing commented Jan 5, 2023

radical commented Jan 5, 2023

ViktorHofer commented Jan 9, 2023 • edited Loading

radical commented Jan 9, 2023 • edited Loading

radical commented Jan 9, 2023

radical commented Jan 9, 2023

ViktorHofer commented Jan 9, 2023

radical commented Jan 9, 2023

ViktorHofer commented Jan 11, 2023

ViktorHofer commented Jan 11, 2023

vitek-karas commented Jan 11, 2023

ViktorHofer commented Jan 11, 2023

tlakollo commented Jan 11, 2023

ViktorHofer commented Jan 11, 2023

ViktorHofer commented Jan 12, 2023

dotnet-maestro bot commented Jan 5, 2023 •

edited

Loading

ViktorHofer commented Jan 9, 2023 •

edited

Loading

radical commented Jan 9, 2023 •

edited

Loading