-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merge-on-Red] - Implement XML log fixer for Helix #80751
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
4686967
Temp log gets written as tests run, rather than just at the end.
ivdiazsa 10747d9
Added placeholder for the XUnit log checker and it now builds with sr…
ivdiazsa 2bc25fe
XUnit Log Checker is now functional in the repo. Next step is to bund…
ivdiazsa b628a21
Making progress in packaging to Helix.
ivdiazsa 8bbacb6
Began adapting the log checker to the actual Helix context.
ivdiazsa 786ed02
XML Fixer builds and works nowgit add *!
ivdiazsa e2e2a27
Forgot to replace the template with the actual values in helixpublish…
ivdiazsa 1b991fc
Fixed a bug with unclosed quotes in the log checker
ivdiazsa 01d9dcf
Fixed wrong log paths in Helix results.
ivdiazsa b550c77
Added missing Wasm logger stuff.
ivdiazsa e445e95
Updated and fixed merge conflicts with main.
ivdiazsa 7c2753e
Fixed a mismatching tag in the log generator, that occurred when reco…
ivdiazsa 9944bdb
Removed some messaging for dev-logging purposes, and fixed a problem …
ivdiazsa f344c31
Added missing stream writer for the temp log in the XHarnessRunner.
ivdiazsa 13a9cb7
Added recorder of test counters.
ivdiazsa 56febb3
Xml's and Csv's work fine now
ivdiazsa 1e4d2c1
Merge branch 'main' into xml-regearing
45e2bd0
Began new approach...
ivdiazsa 2651eb1
XUnitLogChecker should be functional now. Ready to move back from dra…
ivdiazsa 4fa4599
Corrected changed signatures in the XHarnessTestRunner.
ivdiazsa b7e44b7
Fixed a couple issues with browser-wasm generated XHarness test runners.
ivdiazsa f342ede
Attempt to fix Browser-Wasm's weird way of layoutting tests.
ivdiazsa ec5aef0
Browser-Wasm is not possible to implement right here. Removing it...
ivdiazsa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
XUnit Log Checker is now functional in the repo. Next step is to bund…
…le it and have Helix use it as needed.
- Loading branch information
commit 2bc25fe5aaf5c731663611f709856abb8a01d92b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we flush all writes to the xUnit log? Otherwise a crash may end up with an incomplete log finishing with a partial close tag mismatching the corresponding open tag - I guess we may be able to work around it but I suspect it would require a more precise XML scanner - I leave it up to you and Jeremy to decide whether it's worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that would be an issue. For example, let's suppose we are running Methodical_d1.sh. If I click Ctrl-C midrun, it literally stops logging right then and there, so I don't think we would end up with this mismatching example.