Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow setting Parent on the started Activity #81394

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Disallow setting Parent on the started Activity #81394

merged 2 commits into from
Jan 31, 2023

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jan 30, 2023

Fixes #81371

@ghost ghost assigned tarekgh Jan 30, 2023
@ghost
Copy link

ghost commented Jan 30, 2023

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #81371

Author: tarekgh
Assignees: -
Labels:

area-System.Diagnostics.Activity
Milestone: -

@tarekgh tarekgh added this to the 8.0.0 milestone Jan 30, 2023
@tarekgh tarekgh requested a review from noahfalk January 30, 2023 23:37
@tarekgh
Copy link
Member Author

tarekgh commented Jan 30, 2023

@noahfalk @lmolkova

noahfalk
noahfalk approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs Outdated Show resolved Hide resolved
@tarekgh tarekgh merged commit 46841c1 into dotnet:main Jan 31, 2023
@tarekgh tarekgh deleted the FixActivitySetParent branch January 31, 2023 23:02
@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@noahfalk noahfalk noahfalk approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.Diagnostics.Activity
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

It should not be possible to set Activity parent after activity is started
3 participants
@tarekgh @stephentoub @noahfalk