Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnableAotAnalyzer for System.Diagnostics.EventLog #81724

Merged
merged 4 commits into from
Feb 7, 2023
Merged

EnableAotAnalyzer for System.Diagnostics.EventLog #81724

merged 4 commits into from
Feb 7, 2023

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Feb 6, 2023

Contributes to #75480

@ghost ghost assigned eerhardt Feb 6, 2023
@ghost
Copy link

ghost commented Feb 6, 2023

Tagging subscribers to this area: @dotnet/area-system-diagnostics-eventlog
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #75480

Author: eerhardt
Assignees: -
Labels:

area-System.Diagnostics.EventLog
Milestone: -

@eerhardt eerhardt requested a review from jkotas February 6, 2023 21:53
@build-analysis build-analysis bot mentioned this pull request Feb 7, 2023
Closed
jkotas
jkotas approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@eerhardt
Copy link
Member Author

eerhardt commented Feb 7, 2023

runtime (Build Installer Build and Test coreclr linux_musl_arm64 Debug) failure is unrelated.

@jkotas
Copy link
Member

jkotas commented Feb 7, 2023

runtime (Build Installer Build and Test coreclr linux_musl_arm64 Debug) failure is unrelated.

#76905

@jkotas jkotas merged commit 613da8d into dotnet:main Feb 7, 2023
@eerhardt eerhardt deleted the FixEventLogAot branch February 7, 2023 22:34
@ghost ghost locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl left review comments

@jkotas jkotas jkotas approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

@eerhardt eerhardt

Labels
area-System.Diagnostics.EventLog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eerhardt @jkotas @davidfowl @ViktorHofer