Refactor Logging.Console configure options #82254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use nameof instead hard-coded strings - Move the configuration binding code to the options class. This allows the configure method to be virtual and only need a single ConsoleFormatterOptions class. - Minor cleanup
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue Details
Respond to 0f129e4#commitcomment-100824571 feedback.
|
eerhardt
referenced
this pull request
Feb 16, 2023
* Remove ConfigurationBinder usage from Console Logging This allows ConfigurationBinder, and its dependencies like TypeConverter, to be trimmed in an application that uses Console Logging, like an ASP.NET API application. Fix #81931 * Ensure invalid configuration data throws appropriate exception.
tarekgh
approved these changes
Feb 16, 2023
gfoidl
reviewed
Feb 21, 2023
src/libraries/Microsoft.Extensions.Logging.Console/src/ConsoleLoggerOptions.cs
Show resolved
Hide resolved
|
Failures were #82240. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respond to 0f129e4#commitcomment-100824571 feedback.