Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symbolication to XUnitLogChecker #83702

Merged
merged 16 commits into from
Mar 23, 2023
Merged

Add Symbolication to XUnitLogChecker #83702

merged 16 commits into from
Mar 23, 2023

Conversation

ivdiazsa
Copy link
Member

This PR brings a new enhancement to the XUnitLogChecker. In addition to checking and fixing incomplete XML logs, this change adds the functionality to search for dumps and their crash reports, and use them to print the stack trace as additional information when looking at crashes.

@ghost
Copy link

ghost commented Mar 20, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR brings a new enhancement to the XUnitLogChecker. In addition to checking and fixing incomplete XML logs, this change adds the functionality to search for dumps and their crash reports, and use them to print the stack trace as additional information when looking at crashes.

Author: ivdiazsa
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: 8.0.0

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Ivan! I really appreciate your diligence in providing detailed code comments for easier orientation.

@ivdiazsa
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivdiazsa
Copy link
Member Author

/azp run jit-cfg

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivdiazsa
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivdiazsa ivdiazsa merged commit e83f69a into dotnet:main Mar 23, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2023
@ivdiazsa ivdiazsa deleted the log-checker-symbolism branch April 24, 2023 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants