Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Test Watcher Timeout for Test Collections #83746

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Adjust Test Watcher Timeout for Test Collections #83746

merged 3 commits into from
Mar 23, 2023

Conversation

ivdiazsa
Copy link
Member

Addresses issue #83654. This PR introduces a new environment variable, __TestCollectionTimeoutMins, which is used by the watcher in favor of __TestTimeout. This is to have it be able to measure running time more appropriately in test collections work items.

@ivdiazsa
Copy link
Member Author

cc @jakobbotsch

@ghost
Copy link

ghost commented Mar 21, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Addresses issue #83654. This PR introduces a new environment variable, __TestCollectionTimeoutMins, which is used by the watcher in favor of __TestTimeout. This is to have it be able to measure running time more appropriately in test collections work items.

Author: ivdiazsa
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: 8.0.0

@ivdiazsa
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! I will also kick off jit-cfg.

@jakobbotsch
Copy link
Member

/azp run jit-cfg

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Ivan!

@ivdiazsa ivdiazsa merged commit 4d0a300 into dotnet:main Mar 23, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 22, 2023
@ivdiazsa ivdiazsa deleted the watcher-item-timeout branch April 24, 2023 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants