Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching settings.pause_mode to avoid deadlock #84189

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Caching settings.pause_mode to avoid deadlock #84189

merged 1 commit into from
Apr 5, 2023

Conversation

cshung
Copy link
Member

@cshung cshung commented Mar 31, 2023 •
edited
Loading

This fixes #84096.

This comment explains the problem and how this fix works.

Here is the validation done for the PR.

  • GC Perf Sim
    • Normal Server
    • Normal Workstation
    • Large Pages Server
    • Large Pages Workstation
    • Low Memory Container
    • High Memory Load
  • Microbenchmarks
    • V8 Test
    • Top 20 Microbenchmarks
  • ASPNet Benchmarks
    • JsonMin - Windows
    • JsonMin - Linux
    • Fortunes ETF - Windows
    • Fortunes ETF - Linux

@cshung cshung self-assigned this Mar 31, 2023
@ghost
Copy link

ghost commented Mar 31, 2023

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

This fixes #84096.

This comment explains the problem and how this fix works.

Author: cshung
Assignees: cshung
Labels:

area-GC-coreclr
Milestone: -

@cshung cshung merged commit c86c19f into dotnet:main Apr 5, 2023
@cshung cshung deleted the public/avoid-deadlock branch April 5, 2023 18:25
@cshung
Copy link
Member Author

cshung commented Apr 12, 2023

/backport to release/7.0-staging

@github-actions
Copy link
Contributor

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/4683444831

@github-actions github-actions bot mentioned this pull request Apr 12, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Maoni0 Maoni0 Maoni0 approved these changes

Assignees

@cshung cshung

Labels
area-GC-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deadlock when using TryStartNoGCRegion and/or GC.Collect
2 participants
@cshung @Maoni0