Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserving two diagnostic codes for serialization work #84439

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

GrabYourPitchforks
Copy link
Member

Split out from #84383 so that it can be fast-tracked. Reserves obsoletion diagnostic codes while the main PR is under review to help minimize the risk of conflicts.

@ghost
Copy link

ghost commented Apr 6, 2023

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Split out from #84383 so that it can be fast-tracked. Reserves obsoletion diagnostic codes while the main PR is under review to help minimize the risk of conflicts.

Author: GrabYourPitchforks
Assignees: -
Labels:

area-Meta

Milestone: -

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't the first time we've had conflicts arise while obsoleting things. I'll send a PR to augment the obsoletions docs to recommend this approach be taken generally.

@GrabYourPitchforks GrabYourPitchforks merged commit dd44d52 into dotnet:main Apr 6, 2023
@GrabYourPitchforks GrabYourPitchforks deleted the bf_obs_3 branch April 6, 2023 21:01
@ghost ghost locked as resolved and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants