Delete serialization support from the managed type system #84675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long time ago we tried to make binary serialization sort of work with PublishAot. That code was deleted, but this was left.
ghost
assigned 
vitek-karas
approved these changes
Apr 12, 2023
| @@ -147,11 +146,6 @@ private int InitializeFieldFlags(int mask) | |||
| if ((fieldAttributes & FieldAttributes.HasFieldRVA) != 0) | |||
| flags |= FieldFlags.HasRva; | |||
|
|
|||
| #pragma warning disable SYSLIB0050 // Legacy serialization infrastructure is obsolete | |||
| if ((fieldAttributes & FieldAttributes.NotSerialized) != 0) | |||
| flags |= FieldFlags.NotSerialized; | |||
There was a problem hiding this comment.
Should we also remove the FieldFlags.NotSerialized? It should not be used now... and we don't want to use it again.
There was a problem hiding this comment.
It's getting removed on line 21 in this file.
There was a problem hiding this comment.
Right - I'm... blind. Sorry.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long time ago we tried to make binary serialization sort of work with PublishAot. That code was deleted, but this was left.
It required gardening work in #84649 but we should just delete it.
Cc @dotnet/ilc-contrib