Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a number of issues related to boxed value serialization #84768

Merged

Conversation

eiriktsarpalis
Copy link
Member

This PR:

I've split up the PR into three separate commits for easier reviewing.

@ghost
Copy link

ghost commented Apr 13, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR:

I've split up the PR into three separate commits for easier reviewing.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Apr 13, 2023
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 1st and 3rd commits LGTM. The 2nd was more complex and I didn't completely understand all of it. Hopefully someone on the STJ team can give that commit a review.

@eiriktsarpalis eiriktsarpalis merged commit 3a01050 into dotnet:main Apr 19, 2023
@eiriktsarpalis eiriktsarpalis deleted the fix/unspeakable-type-support branch April 19, 2023 17:45
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants