-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a number of issues related to boxed value serialization #84768
Fix a number of issues related to boxed value serialization #84768
Conversation
…g an explicit `Type` parameter.
…t supply metadata for `object`.
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsThis PR:
I've split up the PR into three separate commits for easier reviewing.
|
...aries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/UnspeakableTypeTests.cs
Show resolved
Hide resolved
...ries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/PolymorphicTypeResolver.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 1st and 3rd commits LGTM. The 2nd was more complex and I didn't completely understand all of it. Hopefully someone on the STJ team can give that commit a review.
This PR:
Type
parameter. Unspeakable type support now only works for values that are serialized asobject
types. Fix Add source gen support forunspeakable types
#82457.object
. Fix JSON Serialize as object doesn't work with source generation by default #84704.I've split up the PR into three separate commits for easier reviewing.