Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TargetHostName to QuicConnection #84976

Merged

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Apr 18, 2023

Fixes #80508, also ports #82934 and #81631 to System.Net.Quic to unify behavior.

I discovered that we have some inconsistency in TargetHostName on SslStream side, we will report the encoded TargetHost on client side TargetHostName property and in client cert selection callback, but decoded on server side. So I made changes to always store user-provided TargetHost and encode it only for the parts we need it. I also added a SslStream test for cert validation with IDN domain.

Closes #55687 (added tests which exercise IDN in S.N.Q).

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@rzikm rzikm requested a review from wfurt April 18, 2023 10:44
@rzikm
Copy link
Member Author

rzikm commented Apr 18, 2023

/azp run coreclr-libraries outerloop

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@rzikm
Copy link
Member Author

rzikm commented Apr 18, 2023

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@rzikm
Copy link
Member Author

rzikm commented Apr 18, 2023

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rzikm
Copy link
Member Author

rzikm commented Apr 19, 2023

@rzikm rzikm requested a review from a team April 19, 2023 07:19
@rzikm
Copy link
Member Author

rzikm commented Apr 19, 2023

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but looks good in general, thanks!
BTW, does this also fixes #55687 or is there still something else that needs to be done?

@rzikm
Copy link
Member Author

rzikm commented Apr 20, 2023

BTW, does this also fixes #55687 or is there still something else that needs to be done?

I think this should close it, MsQuic is actually encoding/decoding punycode for us.

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@rzikm
Copy link
Member Author

rzikm commented Apr 21, 2023

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rzikm
Copy link
Member Author

rzikm commented Apr 22, 2023

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rzikm
Copy link
Member Author

rzikm commented Apr 24, 2023

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzikm rzikm merged commit 25b61f6 into dotnet:main Apr 25, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
@karelz karelz added this to the 8.0.0 milestone May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants