Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for merge on red, build analysis, and v1/v2 tests #84982

Merged
merged 11 commits into from
Apr 28, 2023
Merged

Add documentation for merge on red, build analysis, and v1/v2 tests #84982

merged 11 commits into from
Apr 28, 2023

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Apr 18, 2023

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 18, 2023
@ghost ghost assigned hoyosjs Apr 18, 2023
ivdiazsa
ivdiazsa reviewed Apr 18, 2023
View reviewed changes
docs/workflow/README.md Outdated Show resolved Hide resolved
ivdiazsa
ivdiazsa requested changes Apr 18, 2023
View reviewed changes
Copy link
Member

@ivdiazsa ivdiazsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments to address, but overall it looks great. Thank you very much for compiling all this information Juan.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Apr 18, 2023
@ivdiazsa ivdiazsa added the documentation Documentation bug or enhancement, does not impact product or test code label Apr 18, 2023
@ivdiazsa ivdiazsa added this to the 8.0.0 milestone Apr 18, 2023
@jeffhandley jeffhandley added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 20, 2023
@ghost
Copy link

ghost commented Apr 20, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: hoyosjs
Assignees: hoyosjs
Labels:

documentation, area-Infrastructure, needs-author-action
Milestone: 8.0.0

@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Apr 28, 2023
carlossanlop
carlossanlop reviewed Apr 28, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these new docs, they are appreciated!

I left some suggestions for you to consider.

CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/workflow/README.md Outdated Show resolved Hide resolved
docs/workflow/README.md Outdated Show resolved Hide resolved
docs/workflow/ci/failure-analysis.md Show resolved Hide resolved
docs/workflow/ci/failure-analysis.md Outdated Show resolved Hide resolved
docs/workflow/ci/pipelines-overview.md Outdated Show resolved Hide resolved
docs/workflow/ci/pipelines-overview.md Outdated Show resolved Hide resolved
docs/workflow/ci/pipelines-overview.md Outdated Show resolved Hide resolved
docs/workflow/ci/pipelines-overview.md Show resolved Hide resolved
docs/workflow/ci/pipelines-overview.md Outdated Show resolved Hide resolved
@hoyosjs @carlossanlop
Update docs/workflow/README.md
69f5948 
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
@hoyosjs @carlossanlop
Apply suggestions from code review
7912eb6 
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
hoyosjs and others added 3 commits April 27, 2023 22:16
@hoyosjs @carlossanlop
Apply suggestions from code review
f0cad28 
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
@hoyosjs @carlossanlop
Apply suggestions from code review
f252b88 
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
@hoyosjs @carlossanlop
Update docs/workflow/README.md
26be76c 
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
JulieLeeMSFT
JulieLeeMSFT approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@JulieLeeMSFT JulieLeeMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks for the detailed doc. Please add this link to Known Issue template.

carlossanlop
carlossanlop approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

jkoritzinsky
jkoritzinsky reviewed Apr 28, 2023
View reviewed changes
docs/workflow/ci/pipelines-overview.md Outdated Show resolved Hide resolved
docs/workflow/ci/pipelines-overview.md Outdated Show resolved Hide resolved
docs/workflow/ci/pipelines-overview.md Outdated Show resolved Hide resolved
docs/workflow/ci/pipelines-overview.md Outdated Show resolved Hide resolved
docs/workflow/ci/pipelines-overview.md Outdated Show resolved Hide resolved
docs/workflow/ci/pipelines-overview.md Outdated Show resolved Hide resolved
docs/workflow/ci/pipelines-overview.md Outdated Show resolved Hide resolved
@jkoritzinsky
Copy link
Member

I have a few little re-wording suggestions, but other than that LGTM!

ivdiazsa
ivdiazsa approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@ivdiazsa ivdiazsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now with all the suggestions applied! Thanks again for writing these docs!

@hoyosjs hoyosjs merged commit 313074f into dotnet:main Apr 28, 2023
@hoyosjs hoyosjs deleted the juhoyosa/merge-on-red branch April 28, 2023 20:39
@ghost ghost locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky left review comments

@carlossanlop carlossanlop carlossanlop approved these changes

@ivdiazsa ivdiazsa ivdiazsa approved these changes

@JulieLeeMSFT JulieLeeMSFT JulieLeeMSFT approved these changes

@agocke agocke Awaiting requested review from agocke

Assignees

@hoyosjs hoyosjs

Labels
area-Infrastructure documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@hoyosjs @jkoritzinsky @carlossanlop @ivdiazsa @JulieLeeMSFT @jeffhandley