Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HelixPublishWithArcade Compliant With The TargetOS Lowercasing Policy #85357

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Make HelixPublishWithArcade Compliant With The TargetOS Lowercasing Policy #85357

merged 1 commit into from
Apr 26, 2023

Conversation

ivdiazsa
Copy link
Member

Fixes #81141. In PR #80164, the build scripts were updated to always require and/or convert the MSBuild TargetOS property to lowercase. However, the helixpublishwitharcade.proj file was not included in these efforts, which led to some confusing behavior and misplaced files, as described in issue #81141. This PR addresses and fixes that.

@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #81141. In PR #80164, the build scripts were updated to always require and/or convert the MSBuild TargetOS property to lowercase. However, the helixpublishwitharcade.proj file was not included in these efforts, which led to some confusing behavior and misplaced files, as described in issue #81141. This PR addresses and fixes that.

Author: ivdiazsa
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@ivdiazsa ivdiazsa added this to the Future milestone Apr 25, 2023
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks Ivan for identifying and fixing this issue!

@akoeplinger
Copy link
Member

Failures are known issues.

@akoeplinger akoeplinger merged commit 004437e into dotnet:main Apr 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform Specifications Should Match Casing Among All Build Scripts
5 participants