Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generic dictionary lookups for param types and function pointers #85369

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Fix generic dictionary lookups for param types and function pointers #85369

merged 3 commits into from
Apr 26, 2023

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Apr 26, 2023

Fixes #85240

@ghost ghost assigned jkotas Apr 26, 2023
@ghost
Copy link

ghost commented Apr 26, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #85240

Author: jkotas
Assignees: -
Labels:

area-System.Reflection
Milestone: -

@jkotas jkotas force-pushed the issue-85240 branch 2 times, most recently from f17dc59 to 5b8ea00 Compare April 26, 2023 00:44
@build-analysis build-analysis bot mentioned this pull request Apr 26, 2023
Closed
steveharter
steveharter approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@steveharter steveharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this

src/coreclr/vm/typehandle.cpp
{
return GetArrayElementTypeHandle().IsCanonicalSubtype();
return AsTypeDesc()->IsSharedByGenericInstantiations();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - the previous code just ignored IsTypeDesc()

@jkotas jkotas merged commit 1dd5a8c into dotnet:main Apr 26, 2023
@jkotas jkotas deleted the issue-85240 branch April 26, 2023 19:51
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveharter steveharter steveharter approved these changes

@davidwrighton davidwrighton Awaiting requested review from davidwrighton

Assignees

@jkotas jkotas

Labels
area-System.Reflection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function pointer type handles in shared code don't work
2 participants
@jkotas @steveharter