Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: enhance SSA checker to check some PHI properties #85533

Merged
merged 2 commits into from
Apr 28, 2023
Merged

JIT: enhance SSA checker to check some PHI properties #85533

merged 2 commits into from
Apr 28, 2023

Commits on Apr 28, 2023

  1. JIT: enhance SSA checker to check some PHI properties 

    * Ensure PhiArgs have the right local number.
* Ensure PhiArgs have unique `gtPredBB` (for most blocks)

Handler entries may have multiple PhiArgs with the same `gtPredBB`. This
is by design, to model exceptional flow from the middle of the block to a
handler.

Jump threading relies on there being just a single PhiArg per pred.
So exclude handler entry blocks from jump threading.

Prep work for possibly changing SSA to produce one PhiArg per pred, instead
of one PhiArg per ssa def.
    @AndyAyersMS
    AndyAyersMS committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    24f2667 View commit details
    Browse the repository at this point in the history

  2. verify phidef/non-phidef order

    @AndyAyersMS
    AndyAyersMS committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    ca74caf View commit details
    Browse the repository at this point in the history