Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Wasi build on windows, do not set CLR_CMAKE_TARGET_WIN32 #86208

Merged
merged 2 commits into from
May 14, 2023
Merged

For Wasi build on windows, do not set CLR_CMAKE_TARGET_WIN32 #86208

merged 2 commits into from
May 14, 2023

Conversation

yowl
Copy link
Contributor

@yowl yowl commented May 13, 2023

This PR removes CLR_CMAKE_TARGET_WIN32 from eng\native\configureplatform.cmake for the native build of WebAssembly Wasi on windows. Follows discussion at dotnet/runtimelab#2268 (comment)

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 13, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 13, 2023
@yowl yowl mentioned this pull request May 13, 2023
Merged
@teo-tsirpanis teo-tsirpanis added area-Infrastructure os-wasi Related to WASI variant of arch-wasm and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 13, 2023
@ghost
Copy link

ghost commented May 13, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR removes CLR_CMAKE_TARGET_WIN32 from eng\native\configureplatform.cmake for the native build of WebAssembly Wasi on windows. Follows discussion at dotnet/runtimelab#2268 (comment)

Author: yowl
Assignees: -
Labels:

area-Infrastructure, community-contribution, os-wasi
Milestone: -

jkotas
jkotas reviewed May 13, 2023
View reviewed changes
eng/native/configureplatform.cmake Outdated Show resolved Hide resolved
eng/native/configureplatform.cmake Outdated Show resolved Hide resolved
jkotas
jkotas reviewed May 13, 2023
View reviewed changes
eng/native/configureplatform.cmake
endif(CLR_CMAKE_TARGET_UNIX)

if(CLR_CMAKE_TARGET_OS STREQUAL windows)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would look better like this. Does it fix the problem that you tried to fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does thanks.

@yowl
Copy link
Contributor Author

yowl commented May 13, 2023 •
edited
Loading

The failing tests are, one related to cypto which looks unrelated Test System.Security.Cryptography.Rsa.Tests.EncryptDecrypt_TrySpan.RsaCryptRoundtrip_OaepSHA256 has failed and one test
VSTest : error : Tests failed: D:\a\_work\1\s\artifacts\TestResults\Release\AppHost.Bundle.Tests_net8.0_x64.html [net8.0|x64] [D:\a\_work\1\s\src\installer\tests\Microsoft.NET.HostModel.Tests\AppHost.Bundle.Tests\AppHost.Bundle.Tests.csproj] ##[error]VSTest(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Tests failed: D:\a\_work\1\s\artifacts\TestResults\Release\AppHost.Bundle.Tests_net8.0_x64.html [net8.0|x64]

There is also this warning
wasi :
image
##[error].packages\microsoft.dotnet.helix.sdk\8.0.0-beta.23261.4\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(89,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item System.Globalization.Tests in job 4395be70-8bf9-488a-a1ab-771ed8765dd6 has failed. . However that looks "normal" https://dev.azure.com/dnceng-public/public/_build/results?buildId=272914&view=logs&jobId=79537e4b-0c50-5173-cc6b-b5e8e5aeec19&j=79537e4b-0c50-5173-cc6b-b5e8e5aeec19

Worth a rerun maybe?

@jkotas jkotas merged commit f107b63 into dotnet:main May 14, 2023
@yowl yowl deleted the configure-wasi-platform branch May 15, 2023 22:41
@ghost ghost locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yowl @jkotas @teo-tsirpanis