Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable TieredPGO by default #86225

Merged
merged 2 commits into from
May 19, 2023
Merged

enable TieredPGO by default #86225

merged 2 commits into from
May 19, 2023

Conversation

AndyAyersMS
Copy link
Member

No description provided.

@AndyAyersMS AndyAyersMS added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 14, 2023
@ghost ghost assigned AndyAyersMS May 14, 2023
@AndyAyersMS
Copy link
Member Author

Going to start running this across various pipelines to see what might need fixing.

@stephentoub
Copy link
Member

❤️❤️❤️❤️❤️❤️❤️

@AndyAyersMS
Copy link
Member Author

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request May 14, 2023
Closed
@Sewer56
Copy link
Contributor

Sewer56 commented May 14, 2023

💜

@AndyAyersMS
Copy link
Member Author

Looks like tracing.runtimeeventsource times out on linux / osx x64:

  Starting:    tracing.runtimeeventsource.XUnitWrapper (parallel test collections = on, max threads = 2)
   tracing.runtimeeventsource.XUnitWrapper: [Long Running Test] 'tracing/runtimeeventsource/nativeruntimeeventsource/nativeruntimeeventsource.sh', Elapsed: 00:02:11
   tracing.runtimeeventsource.XUnitWrapper: [Long Running Test] 'tracing/runtimeeventsource/nativeruntimeeventsource/nativeruntimeeventsource.sh', Elapsed: 00:04:12
...
   tracing.runtimeeventsource.XUnitWrapper: [Long Running Test] 'tracing/runtimeeventsource/nativeruntimeeventsource/nativeruntimeeventsource.sh', Elapsed: 01:48:12
   tracing.runtimeeventsource.XUnitWrapper: [Long Running Test] 'tracing/runtimeeventsource/nativeruntimeeventsource/nativeruntimeeventsource.sh', Elapsed: 01:50:12
Killed
['PayloadGroup0' END OF WORK ITEM LOG: Command timed out, and was killed]

@AndyAyersMS AndyAyersMS mentioned this pull request May 15, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request May 15, 2023
Closed
@AndyAyersMS
Copy link
Member Author

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request May 18, 2023
Closed
@AndyAyersMS
Copy link
Member Author

Outerloop failures look to be pre-existing (though there are enough that it is hard to be 100% sure).

@AndyAyersMS AndyAyersMS marked this pull request as ready for review May 18, 2023 20:47
@AndyAyersMS AndyAyersMS requested a review from EgorBo May 18, 2023 20:47
@AndyAyersMS
Copy link
Member Author

@EgorBo PTAL

cc @dotnet/jit-contrib

EgorBo
EgorBo approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy

@AndyAyersMS AndyAyersMS merged commit e5c3811 into dotnet:main May 19, 2023
@teo-tsirpanis teo-tsirpanis removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 19, 2023
@EgorBo EgorBo mentioned this pull request May 23, 2023
Open
This was referenced May 30, 2023
Closed
Closed
Closed
Closed
@EgorBo EgorBo mentioned this pull request Jun 1, 2023
Closed
This was referenced Jun 1, 2023
Closed
Closed
@AndyAyersMS AndyAyersMS mentioned this pull request Jun 8, 2023
Closed
This was referenced Jun 8, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 18, 2023
@AndyAyersMS
Copy link
Member Author

Also dotnet/perf-autofiling-issues#18171 (possible dup?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees

@AndyAyersMS AndyAyersMS

Labels
area-TieredCompilation-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndyAyersMS @stephentoub @Sewer56 @EgorBo @teo-tsirpanis