-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugging] Enable debugging when Device Toolbar is enabled and Iphone is selected #86920
Conversation
Tagging subscribers to this area: @thaystg |
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsWhen DevTools is enabled and iPhone 12 is selected, navigatorUA.userAgentData.brands has length = 0 and Debugger was disabled. Fixes:
|
We have similar test in |
As discussed with you, you will work on it. |
|
||
let node_fs: any | undefined = undefined; | ||
let node_url: any | undefined = undefined; | ||
|
||
export async function init_polyfills(module: DotnetModuleInternal): Promise<void> { | ||
export async function detect_features_and_polyfill(module: DotnetModuleInternal): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kg we could start adding more feature detection here on next PRs, like SIMD, MT etc
When DevTools is enabled and iPhone 12 is selected, navigatorUA.userAgentData.brands has length = 0 and Debugger was disabled.
With this PR is possible to debug when Device iPhone is selected.
Fixes:
#84171 (comment)