[wasm][debugger] Fix calling multiple times mono_wasm_asm_loaded when webcil is enabled #87026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
danmoseley
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThe comparison was considering that the extension always had 4 characteres like ".dll" or ".exe" which is not true when webcil is enabled and the extension is ".wasm".
|
lewing
reviewed
Jun 1, 2023
src/mono/wasm/runtime/driver.c
Outdated
Comment on lines
221
to
224
| while (entry != NULL) { | ||
| int entry_name_minus_extn_len = strlen(entry->assembly.name) - 4; | ||
| int entry_name_minus_extn_len = strlen(entry->assembly.name); | ||
| if (entry->assembly.name[entry_name_minus_extn_len - 4] == '.') | ||
| entry_name_minus_extn_len -= 4; //.dll (webcil disabled) |
There was a problem hiding this comment.
maybe something like
int entry_name_minus_extn_len = entry->assembly.name - strrchr (entry->assembly.name, '.');
in case we ever use .webcil etc again.
lambdageek
approved these changes
Jun 2, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison was considering that the extension always had 4 characteres like ".dll" or ".exe" which is not true when webcil is enabled and the extension is ".wasm".