Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enable ILLink analyzers for unsupported TFMs #87071

Merged
merged 10 commits into from
Jun 8, 2023
Merged

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Jun 2, 2023

React to changes in dotnet/sdk#32045. Creating as a draft until we are prepared to update to the preview 6 SDK. This contains fixes for dotnet/source-build#3490, to allow building with a preview 6 SDK.

This contains fixes for dotnet/source-build#3490, as well as fixes for an unrelated build issue that I'm separating into #87074. @ViktorHofer PTAL, and if this looks good @mthalman plans to apply the changes in source-build.

@ghost
Copy link

ghost commented Jun 2, 2023

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

React to changes in dotnet/sdk#32045. Creating as a draft until we are prepared to update to the preview 5 SDK.

Author: sbomer
Assignees: sbomer
Labels:

area-Meta

Milestone: -

@sbomer sbomer requested a review from ViktorHofer June 2, 2023 20:40
@sbomer sbomer marked this pull request as ready for review June 2, 2023 22:54
eng/Analyzers.targets Outdated Show resolved Hide resolved
eng/Analyzers.targets Outdated Show resolved Hide resolved
sbomer and others added 2 commits June 5, 2023 08:50
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
@sbomer sbomer merged commit 56c427b into dotnet:main Jun 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 8, 2023
@sbomer sbomer deleted the updateSDK branch November 3, 2023 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants