Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISC-V][JIT] Fix encoding of CallGCregs #87467

Merged
merged 1 commit into from
Jun 13, 2023
Merged

[RISC-V][JIT] Fix encoding of CallGCregs #87467

merged 1 commit into from
Jun 13, 2023

Conversation

clamp03
Copy link
Member

@clamp03 clamp03 commented Jun 13, 2023 •
edited
Loading

  • It fixes what Encoding and Decoding logic handle CallGCregs differently.

Below tests are fixed (on CHECKED BUILD)

./JIT/Methodical/VT/port/lcs_gcref_do/lcs_gcref_do.sh
./JIT/Methodical/VT/port/lcs_gcref_ro/lcs_gcref_ro.sh
./JIT/Methodical/int64/arrays/lcs_long_do/lcs_long_do.sh
./JIT/Methodical/int64/arrays/lcs_long_il_r/lcs_long_il_r.sh
./JIT/Methodical/int64/arrays/lcs_long_ro/lcs_long_ro.sh
./JIT/Methodical/int64/arrays/lcs_ulong_do/lcs_ulong_do.sh
./JIT/Methodical/int64/arrays/lcs_ulong_ro/lcs_ulong_ro.sh
./JIT/Methodical/int64/arrays/lcs_ulong_il_r/lcs_ulong_il_r.sh
./JIT/opt/OSR/pinnedlocal/pinnedlocal.sh

Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @alpencolt @gbalykov

@clamp03
[RISC-V][JIT] Fix encoding of CallGCregs
e7b5ca1 
- It fixes what Encoding and Decoding logic handle CallGCregs differently.
@clamp03 clamp03 self-assigned this Jun 13, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 13, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 13, 2023
@ghost
Copy link

ghost commented Jun 13, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details
  • It fixes what Encoding and Decoding logic handle CallGCregs differently.
Author: clamp03
Assignees: clamp03
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Jun 13, 2023
@clamp03
Copy link
Member Author

clamp03 commented Jun 13, 2023

@jakobbotsch Could you review? Thank you.

@jakobbotsch jakobbotsch merged commit 363ce9a into dotnet:main Jun 13, 2023
@clamp03 clamp03 deleted the fixbug branch June 13, 2023 23:24
@ghost ghost locked as resolved and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@clamp03 clamp03

Labels
arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clamp03 @jakobbotsch