Don't set mark array bits for UOH objects during concurrent marking #87533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc Issue Detailsmarking UOH objects was a historical thing from a policy we had a long time ago. and I had been meaning to get rid of it. a recent workitem we needed to do makes this actually a necessity. I've done quite a bit testing on this - with stress framework (SVR and WKS) with lots of BGCs and UOH objects allocated during the current marking phase; with various outerloop tests (all passed except I gave up on libraries outerloop as it has so many failures normally. runtime outerloop tests all succeeded).
|
|
@janvorli found out that the osx failure is due to this libuv issue already reported and is fixed in some recent version. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marking UOH objects was a historical thing from a policy we had a long time ago. and I had been meaning to get rid of it. a recent workitem we needed to do makes this actually a necessity.
I've done quite a bit testing on this - with stress framework (SVR and WKS) with lots of BGCs and UOH objects allocated during the current marking phase; with various outerloop tests (all passed except I gave up on libraries outerloop as it has so many failures normally. runtime outerloop tests all succeeded).