Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable reading process environment variables in EventPipe #87771

Merged
merged 7 commits into from
Jul 6, 2023
Merged

Enable reading process environment variables in EventPipe #87771

merged 7 commits into from
Jul 6, 2023

Conversation

LakshanF
Copy link
Member

@LakshanF LakshanF commented Jun 19, 2023 •
edited
Loading

Follows similar pattern as Mono's EventPipe implementation with support for Windows and Linux.

@LakshanF LakshanF added this to the 8.0.0 milestone Jun 19, 2023
@LakshanF LakshanF self-assigned this Jun 19, 2023
@ghost
Copy link

ghost commented Jun 19, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Enabled a test to CI

Author: LakshanF
Assignees: LakshanF
Labels:

area-NativeAOT-coreclr
Milestone: 8.0.0

elinor-fung
elinor-fung approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follows similar pattern as Mono's EventPipe implementation with support for Windows and Linux.

Can you also call this out as another example in that issue you filed some time ago around sharing code in event pipe implementations?

src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp Outdated Show resolved Hide resolved
@LakshanF
Copy link
Member Author

LakshanF commented Jul 6, 2023

Follows similar pattern as Mono's EventPipe implementation with support for Windows and Linux.

Can you also call this out as another example in that issue you filed some time ago around sharing code in event pipe implementations?

Updated #87069

This was referenced Jul 6, 2023
Closed
Closed
@runfoapp runfoapp bot mentioned this pull request Jul 6, 2023
Closed
@LakshanF LakshanF merged commit 2f14594 into dotnet:main Jul 6, 2023
163 of 171 checks passed
@LakshanF LakshanF deleted the ProcessEnvironment branch July 6, 2023 15:12
@build-analysis build-analysis bot mentioned this pull request Jul 7, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elinor-fung elinor-fung elinor-fung approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@LakshanF LakshanF

Labels
area-NativeAOT-coreclr
Projects
AppModel
Status: Done
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LakshanF @elinor-fung