Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from 10 repositories #88245

Merged
merged 45 commits into from
Jul 13, 2023
Merged

[main] Update dependencies from 10 repositories #88245

merged 45 commits into from
Jul 13, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 30, 2023 •
edited
Loading

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.SourceLink.GitHub: from 8.0.0-beta.23314.2 to 8.0.0-beta.23360.2 (parent: Microsoft.DotNet.Arcade.Sdk)
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23319.1 to 1.0.0-beta.23326.1 (parent: Microsoft.DotNet.Arcade.Sdk)

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230711.1
  • Date Produced: July 11, 2023 5:48:23 PM UTC
  • Commit: 2d2482f9b6ccaaac02ef39adc06b3e30b29a5c13
  • Branch: refs/heads/main

From https://github.com/dotnet/sdk

  • Subscription: 736b3d22-d45c-4c36-de26-08db63374d9b
  • Build: 20230711.2
  • Date Produced: July 11, 2023 11:11:36 AM UTC
  • Commit: c0f2dc7643bceb282ed12b2ff5f0e73fa9892262
  • Branch: refs/heads/main

From https://github.com/dotnet/llvm-project

  • Subscription: a7d541fc-4d59-4f09-2997-08d96284e872
  • Build: 20230630.2
  • Date Produced: June 30, 2023 7:06:40 PM UTC
  • Commit: bd3acea90cae502d9a62164b863708d57d7993bc
  • Branch: refs/heads/dotnet/main-16.x

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230709.3
  • Date Produced: July 10, 2023 7:55:19 AM UTC
  • Commit: ab7c452
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20230710.1
  • Date Produced: July 11, 2023 12:42:36 AM UTC
  • Commit: 5cbe29a3ea16c6d20d8f6c551a80e05c5b714aba
  • Branch: refs/heads/dotnet/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20230710.1
  • Date Produced: July 10, 2023 2:30:35 PM UTC
  • Commit: 8362ec8461084d6bcbec2e4371741d0caf2e2e0e
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20230710.1
  • Date Produced: July 10, 2023 5:01:59 PM UTC
  • Commit: 7333879999019e28e47f58879180cba54f5e1843
  • Branch: refs/heads/main

From https://github.com/dotnet/emsdk

  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20230711.2
  • Date Produced: July 11, 2023 11:25:47 PM UTC
  • Commit: afbff08914374ed6790324635b9346d1256680fc
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20230710.3
  • Date Produced: July 10, 2023 4:32:31 PM UTC
  • Commit: ca022cb79bab7a3402802dadec2755e267156793
  • Branch: refs/heads/main

From https://github.com/dotnet/cecil

  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20230710.2
  • Date Produced: July 10, 2023 7:49:05 PM UTC
  • Commit: 1a6a83a8f50e1119f1007b1e3c211d3289ba6901
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
81c45c8 
…629.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23328.2 -> To Version 8.0.0-beta.23329.1

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23319.1 -> To Version 1.0.0-beta.23326.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Jun 30, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20230630.3
cca058f 
Microsoft.DotNet.ApiCompat.Task
 From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-preview.7.23330.3
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/arcade [main] Update dependencies from dotnet/arcade dotnet/sdk Jun 30, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/llvm-project build…
4eebbdc 
… 20230630.2

runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
 From Version 14.0.0-alpha.1.23326.1 -> To Version 16.0.5-alpha.1.23330.2
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/arcade dotnet/sdk [main] Update dependencies from dotnet/arcade dotnet/sdk dotnet/llvm-project Jun 30, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
7adc711 
…630.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23328.2 -> To Version 8.0.0-beta.23330.1

Dependency coherency updates

Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks
 From Version 8.0.0-beta.23314.2 -> To Version 8.0.0-beta.23328.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/arcade dotnet/sdk dotnet/llvm-project [main] Update dependencies from dotnet/sdk dotnet/llvm-project dotnet/arcade Jul 1, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20230630.15
2a94302 
Microsoft.DotNet.ApiCompat.Task
 From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-preview.7.23330.15
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/sdk dotnet/llvm-project dotnet/arcade [main] Update dependencies from dotnet/llvm-project dotnet/arcade dotnet/sdk Jul 1, 2023
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/arcade dotnet/sdk [main] Update dependencies from dotnet/llvm-project dotnet/sdk dotnet/arcade Jul 2, 2023
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/sdk dotnet/arcade [main] Update dependencies from dotnet/llvm-project dotnet/arcade dotnet/sdk Jul 2, 2023
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/arcade dotnet/sdk [main] Update dependencies from dotnet/llvm-project dotnet/sdk dotnet/arcade Jul 3, 2023
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/sdk dotnet/arcade [main] Update dependencies from dotnet/llvm-project dotnet/arcade dotnet/sdk Jul 3, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
511f215 
…0630.6

Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
 From Version 8.0.0-preview.7.23325.2 -> To Version 8.0.0-preview.7.23330.6
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/arcade dotnet/sdk [main] Update dependencies from dotnet/llvm-project dotnet/arcade dotnet/sdk dotnet/runtime Jul 3, 2023
@build-analysis build-analysis bot mentioned this pull request Jul 3, 2023
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
ffd3fab 
…703.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23328.2 -> To Version 8.0.0-beta.23353.2

Dependency coherency updates

Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks
 From Version 8.0.0-beta.23314.2 -> To Version 8.0.0-beta.23330.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/arcade dotnet/sdk dotnet/runtime [main] Update dependencies from dotnet/llvm-project dotnet/sdk dotnet/runtime dotnet/arcade Jul 4, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/icu build 20230703.1
c8737f6 
Microsoft.NETCore.Runtime.ICU.Transport
 From Version 8.0.0-preview.7.23326.2 -> To Version 8.0.0-preview.7.23353.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/sdk dotnet/runtime dotnet/arcade [main] Update dependencies from dotnet/llvm-project dotnet/sdk dotnet/runtime dotnet/arcade dotnet/icu Jul 4, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
219f876 
…ild 20230703.3

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23326.2 -> To Version 8.0.0-alpha.0.23353.3
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/sdk dotnet/runtime dotnet/arcade dotnet/icu [main] Update dependencies from dotnet/llvm-project dotnet/sdk dotnet/runtime dotnet/arcade dotnet/icu dotnet/hotreload-utils Jul 4, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20230704.2
2fe80bd 
Microsoft.DotNet.ApiCompat.Task
 From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-preview.7.23354.2
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/sdk dotnet/runtime dotnet/arcade dotnet/icu dotnet/hotreload-utils [main] Update dependencies from dotnet/llvm-project dotnet/runtime dotnet/arcade dotnet/icu dotnet/hotreload-utils dotnet/sdk Jul 4, 2023
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/runtime dotnet/arcade dotnet/icu dotnet/hotreload-utils dotnet/sdk [main] Update dependencies from dotnet/llvm-project dotnet/runtime dotnet/icu dotnet/hotreload-utils dotnet/sdk dotnet/arcade Jul 5, 2023
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/runtime dotnet/icu dotnet/hotreload-utils dotnet/sdk dotnet/arcade [main] Update dependencies from dotnet/llvm-project dotnet/runtime dotnet/hotreload-utils dotnet/sdk dotnet/arcade dotnet/icu Jul 5, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime-assets bui…
3758dce 
…ld 20230705.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 8.0.0-beta.23326.1 -> To Version 8.0.0-beta.23355.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/runtime dotnet/hotreload-utils dotnet/sdk dotnet/arcade dotnet/icu [main] Update dependencies from dotnet/llvm-project dotnet/runtime dotnet/hotreload-utils dotnet/sdk dotnet/arcade dotnet/icu dotnet/runtime-assets Jul 5, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/emsdk build 202307…
e4bbc78 
…05.1

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-preview.7.23326.1 -> To Version 8.0.0-preview.7.23355.1
@eerhardt
Copy link
Member

@stephentoub @ericstj @ViktorHofer - the source-build leg is failing. It looks like #87857 is causing this.

  /__w/1/s/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/8.0.100-preview.7.23361.2/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(16,5): error MSB4062: The "Microsoft.DotNet.ApiCompat.Task.ValidateAssembliesTask" task could not be loaded from the assembly /__w/1/s/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/8.0.100-preview.7.23361.2/build/../tools/net8.0/Microsoft.DotNet.ApiCompat.Task.dll. Could not load type 'System.Runtime.CompilerServices.NullableContextAttribute' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [/__w/1/s/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
      0 Warning(s)
      1 Error(s)

Can someone take a look at this failure?

@ericstj
Copy link
Member

ericstj commented Jul 11, 2023

So this is a case where we are picking up a new build of the APICompat task built against the nightly net8.0 runtime, but running it on the last-shipped preview 5 runtime. Here we "notice" this torn state because the change to add attributes made it so that nearly every library built took a dependency on the API addition. @ViktorHofer what do you reccomend? Temporarily pausing updates of APICompat until we can pick up a preview7 CLI?

@ViktorHofer
Copy link
Member

ViktorHofer commented Jul 11, 2023 •
edited
Loading

Interesting case. Runtime is the only repository that uses a live APICompat so it's probably OK to pause the update here (while that means that we can't use new features from it for about a month).

I wonder if we depend on any other tools that build against nightlies but then run on the toolset version. The local repo tasks in runtime don't compile against a nightly so they aren't affected.

Just disabled the subscription, filed #88675 and updated this branch.

@build-analysis build-analysis bot mentioned this pull request Jul 11, 2023
Closed
@ViktorHofer ViktorHofer mentioned this pull request Jul 11, 2023
Closed
eiriktsarpalis
eiriktsarpalis reviewed Jul 12, 2023
View reviewed changes
src/libraries/tests.proj Outdated
@@ -28,6 +28,11 @@
<RunWasmSamples Condition="'$(RunSmokeTestsOnly)' != 'true' and '$(RunHighAOTResourceRequiringTestsOnly)' != 'true' and '$(TargetOS)' == 'browser' and '$(BuildAOTTestsOnHelix)' != 'true' and '$(TestWasmBuildTests)' != 'true' and '$(TestWasmDebuggerTests)' != 'true'">true</RunWasmSamples>
</PropertyGroup>

<!-- wasm EAT/AOT -->
<PropertyGroup Condition="'$(TargetOS)' == 'browser' and '$(RunDisabledWasmTests)' != 'true' and '$(EnableAggressiveTrimming)' == 'true'">
<JsonSerializerIsReflectionEnabledByDefault Condition="'$(RunAOTCompilation)' != 'true'">true</JsonSerializerIsReflectionEnabledByDefault>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If testing depends on reflection serialization being available, I would recommend that this flag is turned on unconditionally so that the same components are run regardless of whether it's targeting AOT.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this should be moved to eng/testing/tests.wasm.targets

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If testing depends on reflection serialization being available, I would recommend that this flag is turned on unconditionally so that the same components are run regardless of whether it's targeting AOT.

Yeah this was more me trying to figure out what why only that lane was failing, I had missed the disabling of the other TrimMode=full AOT lanes recently.

dotnet-maestro bot and others added 5 commits July 12, 2023 12:10
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
8ee3c49 
…711.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23328.2 -> To Version 8.0.0-beta.23361.1

Dependency coherency updates

Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks
 From Version 8.0.0-beta.23314.2 -> To Version 8.0.0-beta.23360.2 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/emsdk build 202307…
2690b53 
…11.2

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-preview.7.23326.1 -> To Version 8.0.0-preview.7.23361.2
@radical
move the JsonSerializerIsReflectionEnabledByDefault to tests.wasm.tar…
7a65acb 
…gets
@radical
[wasm] WBT: Fix breaking tests
cc76eff 
`Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations`
broke with the latest sdk:

`/root/helix/work/workitem/e/dotnet-latest/sdk/8.0.100-preview.7.23362.1/Roslyn/Microsoft.CSharp.Core.targets(80,5): error MSB6004: The specified task executable location "/root/helix/work/workitem/e/dotnet-latest/dotnet/dotnet" is invalid.`

This was because dotnet/roslyn#68918 changed
to expect `DOTNET_ROOT` to be a directory instead of the exe path.
@lewing
Update tests.wasm.targets
dd4c97f
@build-analysis build-analysis bot mentioned this pull request Jul 12, 2023
Closed
@lewing
Copy link
Member

lewing commented Jul 12, 2023

And we're back to failing the tests checking for it being disabled.

@radical @eerhardt
Update eng/testing/tests.wasm.targets
569f285 
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
eerhardt and others added 3 commits July 12, 2023 15:13
@eerhardt
Json Trimming tests use DisabledProperties
7893db3
@radical
[wasm] WBT: Set DOTNET_ROOT for tests
399407c
@radical
[wasm] WBT: Set DOTNET_ROOT explicitly in the helix environment
3137ba3 
The `NonWasmTemplateBuildTests` avoid using the default environment
variables used for all other tests, which includes `DOTNET_ROOT`. Set
`DOTNET_ROOT` explicitly in the helix setup script for windows, so we
always have a fallback.

```
    Wasm.Build.Tests.NonWasmTemplateBuildTests.NonWasmConsoleBuild_WithoutWorkload(config: "Debug", extraBuildArgs: "", targetFramework: "net6.0") [FAIL]
       Expected 0 exit code but got 1: C:\helix\work\workitem\e\dotnet-none\dotnet.exe build -restore -c Debug -bl:C:\helix\work\workitem\uploads\xharness-output\logs\nonwasm_net6.0_Debug_iyhtgmvj.uu4.binlog  -f net6.0
      Standard Output:
      [] MSBuild version 17.8.0-preview-23361-03+5ab64ed27 for .NET
      []   Determining projects to restore...
      []   Restored C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj (in 820 ms).
      []   Determining projects to restore...
      []   Restored C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj (in 11.21 sec).
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(314,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : You must install or update .NET to run this application. [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :  [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : App: C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\bincore\csc.dll [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Architecture: x64 [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Framework: 'Microsoft.NETCore.App', version '8.0.0-preview.7.23361.9' (x64) [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : .NET location: C:\helix\work\correlation\dotnet-cli\ [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :  [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : The following frameworks were found: [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :   8.0.0-preview.5.23280.8 at [C:\helix\work\correlation\dotnet-cli\shared\Microsoft.NETCore.App] [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :  [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Learn more: [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : https://aka.ms/dotnet/app-launch-failed [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error :  [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : To install missing framework, download: [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0-preview.7.23361.9&arch=x64&rid=win10-x64 [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj]
      []
```
@lewing
Copy link
Member

lewing commented Jul 13, 2023

Failures are known

@lewing lewing merged commit 1a7fa89 into main Jul 13, 2023
170 of 179 checks passed
@lewing lewing deleted the darc-main-91f3883a-a0f9-4c19-9ddb-dfd6a5991174 branch July 13, 2023 02:09
This was referenced Jul 13, 2023
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
ericstj
ericstj reviewed Sep 22, 2023
View reviewed changes
eng/Versions.props
<MicrosoftExtensionsDependencyModelVersion>6.0.0</MicrosoftExtensionsDependencyModelVersion>
<!-- CoreClr dependencies -->
<MicrosoftNETCoreILAsmVersion>8.0.0-preview.7.23359.3</MicrosoftNETCoreILAsmVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this change added a second ILAsm property. After this darc is only updating the first one, which gets overwritten by the second.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical left review comments

@lewing lewing lewing approved these changes

@eiriktsarpalis eiriktsarpalis eiriktsarpalis left review comments

@eerhardt eerhardt eerhardt left review comments

@ericstj ericstj ericstj left review comments

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@radical @directhex @lewing @sbomer @eerhardt @ericstj @ViktorHofer @eiriktsarpalis