Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][interp] Tweaks to x86 call convention handling #88466

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[mono][interp] Tweaks to x86 call convention handling #88466

merged 1 commit into from
Jul 7, 2023
+11 −5

Commits on Jul 7, 2023

  1. [mono][interp] Tweaks to x86 call convention handling 

    First, we no longer assert that the call convetion is cdecl on the slowpath. The pinvoke trampoline on x86 restores the saved stack pointer so it doesn't matter if the pinvoke callee pops or not the stack. Therefore both stdcall and cdecl calls should be supported with the same path. Untested.

Second, we use the fastpath (which uses the C call convention) only if the pinvoke signature is also cdecl, otherwise we have cconv mismatch.
    @BrzVlad
    BrzVlad committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    dbfd395 View commit details
    Browse the repository at this point in the history