Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DOTNET_MaxVectorTBitwidth is interpreted as a decimal based input, not hexadecimal #88761

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

tannergooding
Copy link
Member

@tannergooding tannergooding commented Jul 12, 2023

As per the title, this simply ensures that DOTNET_MaxVectorTBitWidth=256 is interpreted as 256 and not as 598. This will better match user expectations for the value, matches the value users pass into NAOT for the equivalent configuration knob, etc.

An equivalent to ReinterpretHexAsDecimal already exists for the JIT config values and is being used by various options, including PreferredVectorBitWidth.

I missed that CLRConfig::LookupOptions::ParseIntegerAsBase10 exists and have updated to use that instead.

@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib, @jkotas

A simple one line change to the DOTNET_MaxVectorTBitWidth config value so its interpreted as decimal and consistent with how the same parameter is interpreted for NAOT, etc

@EgorBo
Copy link
Member

EgorBo commented Jul 13, 2023

I really dislike our "hex by default" behavior but I guess there is nothing we can do about it now

@tannergooding tannergooding merged commit 33e0669 into dotnet:main Jul 13, 2023
101 of 107 checks passed
@tannergooding tannergooding deleted the maxvectortbitwidth branch July 13, 2023 15:58
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants