Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][jit] Don't truncate the high bits when ldelema index is nint #88986

Merged
merged 5 commits into from
Sep 8, 2023
Merged

[mono][jit] Don't truncate the high bits when ldelema index is nint #88986

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aaab7df
[mono][interp] Remove dead code
BrzVlad Jul 14, 2023
f5031cf
[tests] Move issue to interp only
BrzVlad Jul 17, 2023
cad4e2e
[mono][jit] Fix bounds check when index is nint
BrzVlad Jul 14, 2023
caf60c0
[mono][interp] Add missing sign extend
BrzVlad Jul 19, 2023
1c5819f
feedback
BrzVlad Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[mono][interp] Remove dead code
  • Loading branch information
@BrzVlad
BrzVlad committed Aug 22, 2023
commit aaab7dffaa1366ce6d9893bedbf31910baf85b1e
21 changes: 0 additions & 21 deletions src/mono/mono/mini/interp/interp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,27 +1211,6 @@ ves_array_calculate_index (MonoArray *ao, stackval *sp, gboolean safe)
return pos;
}

static MonoException*
ves_array_get (InterpFrame *frame, stackval *sp, stackval *retval, MonoMethodSignature *sig, gboolean safe)
{
MonoObject *o = sp->data.o;
MonoArray *ao = (MonoArray *) o;
MonoClass *ac = o->vtable->klass;

g_assert (m_class_get_rank (ac) >= 1);

gint32 pos = ves_array_calculate_index (ao, sp + 1, safe);
if (pos == -1)
return mono_get_exception_index_out_of_range ();

gint32 esize = mono_array_element_size (ac);
gconstpointer ea = mono_array_addr_with_size_fast (ao, esize, pos);

MonoType *mt = sig->ret;
stackval_from_data (mt, retval, ea, FALSE);
return NULL;
}

static MonoException*
ves_array_element_address (InterpFrame *frame, MonoClass *required_type, MonoArray *ao, gpointer *ret, stackval *sp, gboolean needs_typecheck)
{
Expand Down